Added Godep support. Fixes #16

nathany / looper

Go autotesting tool with readline support.

BSD 2-Clause "Simplified" License

390 stars 40 forks source link

Added Godep support. Fixes #16 #17

Closed sudhirj closed 9 years ago

sudhirj commented 9 years ago

Fixes #16

Checks for the existence of a Godeps folder and run godeps go test instead.

sudhirj commented 9 years ago

@nathany Been using this branch for a while now, and there don't seem to be issues. Does it make sense to you?

nathany commented 9 years ago

@sudhirj Thanks for submitting this pull request, and I apologize for not looking at it sooner.

[x] It looks like other tools may use "Godeps" (see GPM). Perhaps we should check for the actual Godeps.json file?
[ ] What happens if you run Looper inside a subfolder of the larger project? Should we be searching up the folder structure for Godeps?

sudhirj commented 9 years ago

I think both points make sense. The first one is easier, but the second one poses the question of how far up the tree to search. Does looper currently head to the root directory to run tests?

nathany commented 9 years ago

No it doesn't. It just runs tests for the package in the current directory and directories below it.

We can leave the second one for now. The result will just be that it continues to use "go test" if not inside the same folder as Godeps.

sudhirj commented 9 years ago

Changed to check for the Godeps.json instead.

nathany commented 9 years ago

Thanks for your contribution. Release v0.3.0.