search

nathany / looper

Go autotesting tool with readline support.
BSD 2-Clause "Simplified" License
390 stars 40 forks source link

Using the recwatch package #23

Closed xyproto closed 9 years ago

xyproto commented 9 years ago

Being able to watch directories recursively was a very useful feature, and I used your code in Algernon. Thanks for writing it!

Now, this pull request is only a suggestion. Accept, reject or ask me to make modifications at will.

I think splitting out the recursive watch functionality into a separate package is a good idea.

If you should happen to want to host recwatch or a similar package on github somewhere, I would be happy to use that one instead of the fork of your code.

Best regards, Alexander F Rødseth

nathany commented 9 years ago

Thanks Alexander. I think I'll just keep with the current implementation until fsnotify adds support for recursive watches. https://github.com/go-fsnotify/fsnotify/issues/18

xyproto commented 9 years ago

OK, understandable.