Bump data.xml so the library will work with clojure 1.9.0

nathell / clj-tagsoup

A HTML parser for Clojure.

Other

181 stars 22 forks source link

Bump data.xml so the library will work with clojure 1.9.0 #20

Closed madstap closed 4 years ago

madstap commented 7 years ago

data.xml 0.0.3 has a malformed defn somewhere that won't compile with 1.9.0-alpha12 because defn got spec'd. see #18 Bumped it to 0.0.8 which is the latest stable version. Also started on a test suite to see if anything broke.

madstap commented 7 years ago

I removed the version range as well, because reasons from this blog post

See #10

~leiningen apparently downloads every version of clojure from 1.2.0 -> 1.9.0 when I run lein test~
downloads poms for all clojure versions
in projects using this leiningen demands I do [clj-tagsoup :exlusions [org.clojure/clojure]]

ezmiller commented 7 years ago

+1 for this. I guess it's related to this warning I'm seeing:

WARNING!!! version ranges found for: [clj-tagsoup "0.3.0"] -> [org.clojure/clojure "[1.2.0,)"] Consider using [clj-tagsoup "0.3.0" :exclusions [org.clojure/clojure]].

jumarko commented 7 years ago

Any plans to release new version of clj-tagsoup with this fix?

ivarref commented 7 years ago

+1 for @jumarko Hope to see new release. @nathell

nabacg commented 5 years ago

This is still broken on clojure 1.10, any plans to release this fix?

(use 'pl.danieljanus.tagsoup)
Syntax error compiling at (tagsoup.clj:1:1).
namespace 'clojure.data.xml' not found

sirmspencer commented 4 years ago

@nathell Can you please merge this and update the package? The PR is 3 years old at this point.

nathell commented 4 years ago

Done – apologies to everyone for the lack of love for clj-tagsoup in the last years.