search

nathggns / Scaffold

Lightweight PHP API Framework
Other
8 stars 2 forks source link

Change default level to 2 #120

Closed andrewhathaway closed 11 years ago

andrewhathaway commented 11 years ago

Discussed with Nathaniel.

nathggns commented 11 years ago

This will mean first level relationships will be part of exported data.

nathggns commented 11 years ago

Actually, this shouldn't happened, because as it's level 1, this will already happen for single mode models. Currently however, stepping into a multiple mode model decrements the level. This should happen.

nathggns commented 11 years ago

f0a59fef224c17c4cb7144118916957cf6e71d70 implements this @ClaudioAlbertin

coveralls commented 11 years ago

Coverage Status

Coverage remained the same when pulling f0a59fef224c17c4cb7144118916957cf6e71d70 on issue-120 into 7ed9378c360294a75389e87d417b66d964175f5d on development.

ClaudioAlbertin commented 11 years ago

Export data shouldn't contain any relationships by default.

nathggns commented 11 years ago

Hmm. Okay, I can agree with that.

nathggns commented 11 years ago

This is ready now @ClaudioAlbertin

coveralls commented 11 years ago

Coverage Status

Coverage remained the same when pulling c1d4e5ae4221d6a336c671ce027987361f89b246 on issue-120 into 7ed9378c360294a75389e87d417b66d964175f5d on development.

coveralls commented 11 years ago

Coverage Status

Coverage remained the same when pulling c1d4e5ae4221d6a336c671ce027987361f89b246 on issue-120 into 7ed9378c360294a75389e87d417b66d964175f5d on development.

ClaudioAlbertin commented 11 years ago

Add argument shuffling for export() maybe? :3

nathggns commented 11 years ago

Okay, will do.  — Nathaniel Higgins http://nath.is

On Sat, Jun 8, 2013 at 10:05 PM, Claudio Albertin notifications@github.com wrote:

Add argument shuffling for export() maybe? :3

Reply to this email directly or view it on GitHub: https://github.com/Scaffold/Scaffold/pull/120#issuecomment-19155469

coveralls commented 11 years ago

Coverage Status

Coverage increased (+7.29%) when pulling edaece27ecefbf133ad02bd1ff81288d26c286f0 on issue-120 into 7ed9378c360294a75389e87d417b66d964175f5d on development.

nathggns commented 11 years ago

This should be mergeable now @ClaudioAlbertin?

ClaudioAlbertin commented 11 years ago

Merge it then.