Closed jaredmcateer closed 11 years ago
This is going to need an option to disable logging. Want to do it? I could merge it to a separate branch and add logging myself?
Oh sure I don't mind adding it.
Yeh add that then (and to the README) and ill merge. — Nathaniel Higgins http://nath.is
On Sun, Apr 7, 2013 at 11:20 PM, Jared McAteer notifications@github.com wrote:
Oh sure I don't mind adding it.
Reply to this email directly or view it on GitHub: https://github.com/nathggns/node-compass/pull/13#issuecomment-16025613
Added a logging option and defaulted it to false. Also cleaned up the code a bit there was an option I had left in there when I was messing around with some ideas that didn't do what I thought it did that I also removed. Updated the readme to reflect the new option.
Also, I don't know if it's possible, but could you try and merge this pull request to merge it into the new development branch please?
In order to do that I would have to create a new request, I have no problem doing that. Alternatively if you want to get fancy you can use the Github API to switch this one using:
curl --user "nathggns:<PASSWORD>" \
--request PATCH \
--data '{"issue": "13", "head": "nathggns:development", "base": "master"}' \
https://api.github.com/repos/nathggns/node-compass/pulls
This appears to result in a 404. Sure you got that right?
Nope, I've only seen it on stackoverflow, haven't tried it. :) well I'll just create a new pull request.
On Wed, Apr 10, 2013 at 10:29 AM, Nathaniel Higgins < notifications@github.com> wrote:
This appears to result in a 404. Sure you got that right?
— Reply to this email directly or view it on GitHubhttps://github.com/nathggns/node-compass/pull/13#issuecomment-16185504 .
Cool:) — Nathaniel Higgins http://nath.is
On Thu, Apr 11, 2013 at 1:46 AM, Jared McAteer notifications@github.com wrote:
Nope, I've only seen it on stackoverflow, haven't tried it. :) well I'll just create a new pull request. On Wed, Apr 10, 2013 at 10:29 AM, Nathaniel Higgins < notifications@github.com> wrote:
This appears to result in a 404. Sure you got that right?
— Reply to this email directly or view it on GitHubhttps://github.com/nathggns/node-compass/pull/13#issuecomment-16185504 .
Reply to this email directly or view it on GitHub: https://github.com/nathggns/node-compass/pull/13#issuecomment-16211254
Opened #14
Compass may fail at compiling if the spawn command is passed a blank string which will happen for non-default values for the opts.comments and opts.relative options.
The solution is to move option collating outside of the spawn command so if the option isn't setting a switch, it will not do anything.
I've also added logging to provide the user with feedback as to what is going on when the middleware is trying to compile their stylesheets.