nathom / streamrip

A scriptable music downloader for Qobuz, Tidal, SoundCloud, and Deezer
GNU General Public License v3.0
2.73k stars 247 forks source link

[BUG] Device Authorization Failed (on Tidal) #293

Closed agithubuser420 closed 2 years ago

agithubuser420 commented 2 years ago

Describe the bug

Device Authorization Failed. Trying to run the tidal command shoots an authorization error

Command Used

rip config --tidal

Debug Traceback

rip config --tidal -vvv
DEBUG:streamrip:Config loaded
DEBUG:streamrip:Logging in as a new user

  Stack trace:

  9  xxxxxxx\python39\lib\site-packages\cleo\application.py:330 in run
      328│
      329│             try:
    → 330│                 exit_code = self._run(io)
      331│             except Exception as e:
      332│                 if not self._catch_exceptions:

  8  xxxxxxx\python\python39\lib\site-packages\rip\cli.py:759 in _run
      757│             logger.addHandler(fh)
      758│
    → 759│         super()._run(io)
      760│
      761│     def create_io(self, input=None, output=None, error_output=None):

  7  xxxxxxx\\python39\lib\site-packages\cleo\application.py:425 in _run
      423│                 io.set_input(ArgvInput(argv))
      424│
    → 425│         exit_code = self._run_command(command, io)
      426│         self._running_command = None
      427│

  6  xxxxxxx\python39\lib\site-packages\cleo\application.py:432 in _run_command
      430│     def _run_command(self, command: Command, io: IO) -> int:
      431│         if self._event_dispatcher is None:
    → 432│             return command.run(io)
      433│
      434│         # Bind before the console.command event,

  5  xxxxxxx\python39\lib\site-packages\cleo\commands\base_command.py:118 in run
      116│         io.input.validate()
      117│
    → 118│         status_code = self.execute(io)
      119│
      120│         if status_code is None:

  4  xxxxxxx\python39\lib\site-packages\cleo\commands\command.py:85 in execute
       83│
       84│         try:
    →  85│             return self.handle()
       86│         except KeyboardInterrupt:
       87│             return 1

  3  xxxxxxx\python39\lib\site-packages\rip\cli.py:449 in handle

      447│
      448│             client = TidalClient()
    → 449│             client.login()
      450│             self._config.file["tidal"].update(client.get_tokens())
      451│             self._config.save()

  2  xxxxxxx\python39\lib\site-packages\streamrip\clients.py:761 in login
       759│         else:
       760│             logger.debug("Logging in as a new user")
    →  761│             self._login_new_user()
       762│
       763│         self.logged_in = True

  1  xxxxxxxx\python39\lib\site-packages\streamrip\clients.py:846 in _login_new_user
       844│         :type launch: bool
       845│         """
    →  846│         login_link = f"https://{self._get_device_code()}"
       847│
       848│         secho(

  Exception

  Device authorization failed {'status': 401, 'error': 'invalid_client', 'error_description': 'Client with token[not sure if this is confidential] not found', 'sub_status': 1005}

  at xxxxxxx\python39\lib\site-packages\streamrip\clients.py:881 in _get_device_code
       877│         }
       878│         resp = self._api_post(f"{TIDAL_AUTH_URL}/device_authorization", data)
       879│
       880│         if resp.get("status", 200) != 200:
    →  881│             raise Exception(f"Device authorization failed {resp}")
       882│
       883│         self.device_code = resp["deviceCode"]
       884│         self.user_code = resp["userCode"]
       885│         self.user_code_expiry = resp["expiresIn"]

If this was unexpected, please open a Bug Report at https://github.com/nathom/streamrip/issues/new/choose

Config File

[downloads]
# Folder where tracks are downloaded to
folder = ""
# Put Qobuz albums in a 'Qobuz' folder, Tidal albums in 'Tidal' etc.
source_subdirectories = false

[downloads.concurrency]
# Download (and convert) tracks all at once, instead of sequentially. 
# If you are converting the tracks, or have fast internet, this will 
# substantially improve processing speed.
enabled = true
# The maximum number of tracks to download at once
# If you have very fast internet, you will benefit from a higher value,
# A value that is too high for your bandwidth may cause slowdowns
max_connections = 3

[qobuz]
# 1: 320kbps MP3, 2: 16/44.1, 3: 24/<=96, 4: 24/>=96
quality = 3
# This will download booklet pdfs that are included with some albums
download_booklets = true

email = ""
# This is an md5 hash of the plaintext password
password = ""
# Do not change
app_id = ""
# Do not change
secrets = []

[tidal]
# 0: 256kbps AAC, 1: 320kbps AAC, 2: 16/44.1 "HiFi" FLAC, 3: 24/44.1 "MQA" FLAC
quality = 3
# This will download videos included in Video Albums.
download_videos = true

# Do not change any of the fields below
user_id = ""
country_code = ""
access_token = ""
refresh_token = ""
# Tokens last 1 week after refresh. This is the Unix timestamp of the expiration
# time. If you haven't used streamrip in more than a week, you may have to log
# in again using `rip config --tidal`
token_expiry = ""

[deezer]
# 0, 1, or 2
# This only applies to paid Deezer subscriptions. Those using deezloader
# are automatically limited to quality = 1
quality = 2
# An authentication cookie that allows streamrip to use your Deezer account
# See https://github.com/nathom/streamrip/wiki/Finding-Your-Deezer-ARL-Cookie
# for instructions on how to find this
arl = ""
# This allows for free 320kbps MP3 downloads from Deezer
# If an arl is provided, deezloader is never used
use_deezloader = true
# This warns you when the paid deezer account is not logged in and rip falls
# back to deezloader, which is unreliable
deezloader_warnings = true

[soundcloud]
# Only 0 is available for now
quality = 0
# This changes periodically, so it needs to be updated
client_id = ""
app_version = ""

[youtube]
# Only 0 is available for now
quality = 0
# Download the video along with the audio
download_videos = false
# The path to download the videos to
video_downloads_folder = ""

# This stores a list of item IDs so that repeats are not downloaded.
[database.downloads]
enabled = true
path = ""

# If a download fails, the item ID is stored here. Then, `rip repair` can be
# called to retry the downloads
[database.failed_downloads]
enabled = true
path = ""

# Convert tracks to a codec after downloading them.
[conversion]
enabled = false
# FLAC, ALAC, OPUS, MP3, VORBIS, or AAC
codec = "ALAC"
# In Hz. Tracks are downsampled if their sampling rate is greater than this. 
# Value of 48000 is recommended to maximize quality and minimize space
sampling_rate = 48000
# Only 16 and 24 are available. It is only applied when the bit depth is higher
# than this value.
bit_depth = 24
# Only applicable for lossy codecs
lossy_bitrate = 320

# Filter a Qobuz artist's discography. Set to 'true' to turn on a filter.
[filters]
# Remove Collectors Editions, live recordings, etc.
extras = false
# Picks the highest quality out of albums with identical titles.
repeats = false
# Remove EPs and Singles
non_albums = false
# Remove albums whose artist is not the one requested
features = false
# Skip non studio albums
non_studio_albums = false
# Only download remastered albums
non_remaster = false

[artwork]
# Write the image to the audio file
embed = true
# The size of the artwork to embed. Options: thumbnail, small, large, original.
# "original" images can be up to 30MB, and may fail embedding. 
# Using "large" is recommended.
size = "large"
# Both of these options limit the size of the embedded artwork. If their values
# are larger than the actual dimensions of the image, they will be ignored.
# If either value is -1, the image is left untouched.
max_width = -1
max_height = -1
# Save the cover image at the highest quality as a seperate jpg file
keep_hires_cover = true

[metadata]
# Sets the value of the 'ALBUM' field in the metadata to the playlist's name. 
# This is useful if your music library software organizes tracks based on album name.
set_playlist_to_album = true
# Replaces the original track's tracknumber with it's position in the playlist
new_playlist_tracknumbers = true
# The following metadata tags won't be applied
# See https://github.com/nathom/streamrip/wiki/Metadata-Tag-Names for more info
exclude = []

# Changes the folder and file names generated by streamrip.
[filepaths]
# Create folders for single tracks within the downloads directory using the folder_format
# template
add_singles_to_folder = false
# Available keys: "albumartist", "title", "year", "bit_depth", "sampling_rate",
# "container", "id", and "albumcomposer"
folder_format = "{albumartist} - {title} ({year}) [{container}] [{bit_depth}B-{sampling_rate}kHz]"
# Available keys: "tracknumber", "artist", "albumartist", "composer", "title",
# and "albumcomposer"
track_format = "{tracknumber}. {artist} - {title}{explicit}"
# Only allow printable ASCII characters in filenames.
restrict_characters = false

# Last.fm playlists are downloaded by searching for the titles of the tracks
[lastfm]
# The source on which to search for the tracks.
source = "qobuz"
# If no results were found with the primary source, the item is searched for 
# on this one.
fallback_source = "deezer"

[theme]
# Options: "dainty" or "plain"
progress_bar = "dainty"

[misc]
# Metadata to identify this config file. Do not change.
version = "1.9.2"

Operating System

windows

streamrip version

1.9.3

Screenshots and recordings

No response

Additional context

Used the program last night with no issues, but today authorization problems. I reset the config which is why it is currently blank but before I did, I was unable to dl using my working credentials. Looking on the TMD github, they are experiencing the same issues it seems. EDIT: The config says I'm running version 1.9.2 but I'm on the latest 1.9.3

AllKind commented 2 years ago

Tried v.1.9.3 yet? I think the access token got updated.

agithubuser420 commented 2 years ago

hmmm I just realized that discrepancy. I just blindly copied over the 1.9.2 from the config file after I updated streamrip. I am in fact running 1.9.3, but when I run the config file it says 1.9.2 still. I updated my original post to indicate the correct version, thank you

mirsemen commented 2 years ago

On Gentoo Linux the same error. Version 1.9.3.

CanadianBaconBoi commented 2 years ago

They've revoked the API credentials again, you'll just have to wait for streamrip to update.

bonfire62 commented 2 years ago

Having the same issue here, windows 1.9.3

AllKind commented 2 years ago

@CanadianBaconBoi I worked out to fiddler the: x-tidal-token, authorization: Bearer and client_id= & client_unique_key= from the windows desktop app (I think those, or at least some, I'd need). Is there a way to add them manually to streamrip? I tried to put them into constants.py (id and secret (not in encoded way, like it seems to be done now)), but didn't work for me. I'm no programmer so,... Or does this not work with the token from the desktop app?

cmasta42 commented 2 years ago

They've revoked the API credentials again, you'll just have to wait for streamrip to update.

How often they revoke API credentials? Do you know?

nayab9 commented 2 years ago

is this a solvable issue? or can they just ban all the clients? is there a way for us to extract our own unique client id/secret from our own apps to avoid this?

gidisegal commented 2 years ago

is this a solvable issue? or can they just ban all the clients? is there a way for us to extract our own unique client id/secret from our own apps to avoid this?

I believe the issue is that our own apps stream using dash+xml which streamrip doesnt currently support hence why they need to use the ids of other devices

gidisegal commented 2 years ago

perhaps dash+xml streaming can be implemented into streamrip? like in https://github.com/DDKnoll/Tidal-Media-Downloader/

nayab9 commented 2 years ago

perhaps dash+xml streaming can be implemented into streamrip? like in https://github.com/DDKnoll/Tidal-Media-Downloader/

Thanks for the link to this fork @gidisegal!!! It works like a charm!

cmasta42 commented 2 years ago

perhaps dash+xml streaming can be implemented into streamrip? like in https://github.com/DDKnoll/Tidal-Media-Downloader/

Been trying to get this to work! not the proper channel but I always get stuck on the [ERR] countryCode parameter missing when using this, am I just a brick not doing something correctly? New to installing GitHub software :P

gidisegal commented 2 years ago

https://github.com/yaronzz/Tidal-Media-Downloader/issues/834#issuecomment-1029464775

perhaps dash+xml streaming can be implemented into streamrip? like in https://github.com/DDKnoll/Tidal-Media-Downloader/

Been trying to get this to work! not the proper channel but I always get stuck on the [ERR] countryCode parameter missing when using this, am I just a brick not doing something correctly? New to installing GitHub software :P

cmasta42 commented 2 years ago

thank you! works like a charm and was pretty easy to follow

jayden000 commented 2 years ago

297 fixes this

nathom commented 2 years ago

Should be fixed in 1.9.4.