[BUG] Ripping artist from Qobuz stops when it detects existing album

[ghost]

Describe the bug

When i try to rip a whole artist, if I stop the download and restart it, it just says "(filename) already exists. Skipping". It doesn't check if other albums are downloaded or not. Not only that, if you're in the middle of downloading an artist, it can just say "something already exists" and you can't properly download the rest.

Command Used

rip url https://play.qobuz.com/artist/70899

Debug Traceback

Can't post because it's too long.

Logging into qobuz

Downloading Taylor Swift (Artist)

Downloading Red (Taylor's Version) (Album)

Downloading cover art (original)

"/home/dragonightfury/torrentslocal/Music/Taylor Swift/Taylor Swift - Red (Taylor's Version) (2021) [FLAC] [24B-96kHz]/01. Taylor Swift - State Of Grace (Taylor's Version) (Explicit).flac" already exists. Skipping.

Config File

[downloads]
# Folder where tracks are downloaded to
folder = "/home/dragonightfury/torrentslocal/Music/"
# Put Qobuz albums in a 'Qobuz' folder, Tidal albums in 'Tidal' etc.
source_subdirectories = false

[downloads.concurrency]
# Download (and convert) tracks all at once, instead of sequentially. 
# If you are converting the tracks, or have fast internet, this will 
# substantially improve processing speed.
enabled = true
# The maximum number of tracks to download at once
# If you have very fast internet, you will benefit from a higher value,
# A value that is too high for your bandwidth may cause slowdowns
max_connections = 32

[qobuz]
# 1: 320kbps MP3, 2: 16/44.1, 3: 24/<=96, 4: 24/>=96
quality = 4
# This will download booklet pdfs that are included with some albums
download_booklets = true

email = 
# This is an md5 hash of the plaintext password
password = {REDACTED}
# Do not change
app_id = "814460817"
# Do not change
secrets = secret ;)

[tidal]
# 0: 256kbps AAC, 1: 320kbps AAC, 2: 16/44.1 "HiFi" FLAC, 3: 24/44.1 "MQA" FLAC
quality = 3
# This will download videos included in Video Albums.
download_videos = true

# Do not change any of the fields below
user_id = ""
country_code = ""
access_token = ""
refresh_token = ""
# Tokens last 1 week after refresh. This is the Unix timestamp of the expiration
# time. If you haven't used streamrip in more than a week, you may have to log
# in again using `rip config --tidal`
token_expiry = ""

[deezer]
# 0, 1, or 2
# This only applies to paid Deezer subscriptions. Those using deezloader
# are automatically limited to quality = 1
quality = 2
# An authentication cookie that allows streamrip to use your Deezer account
# See https://github.com/nathom/streamrip/wiki/Finding-Your-Deezer-ARL-Cookie
# for instructions on how to find this
arl = ""
# This allows for free 320kbps MP3 downloads from Deezer
# If an arl is provided, deezloader is never used
use_deezloader = true
# This warns you when the paid deezer account is not logged in and rip falls
# back to deezloader, which is unreliable
deezloader_warnings = true

[soundcloud]
# Only 0 is available for now
quality = 0
# This changes periodically, so it needs to be updated
client_id = ""
app_version = ""

[youtube]
# Only 0 is available for now
quality = 0
# Download the video along with the audio
download_videos = false
# The path to download the videos to
video_downloads_folder = ""

# This stores a list of item IDs so that repeats are not downloaded.

[database.downloads]
enabled = true
#path = "/home/dragonightfury/streamrip_databases/"
path = "/home/dragonightfury/.config/streamrip/downloads.db"

# If a download fails, the item ID is stored here. Then, `rip repair` can be
# called to retry the downloads

[database.failed_downloads]
enabled = true
#path = "/home/dragonightfury/streamrip_databases/"
path = "/home/dragonightfury/.config/streamrip/failed_downloads.db"

# Convert tracks to a codec after downloading them.

[conversion]
enabled = false
# FLAC, ALAC, OPUS, MP3, VORBIS, or AAC
codec = "ALAC"
# In Hz. Tracks are downsampled if their sampling rate is greater than this. 
# Value of 48000 is recommended to maximize quality and minimize space
sampling_rate = 48000
# Only 16 and 24 are available. It is only applied when the bit depth is higher
# than this value.
bit_depth = 24
# Only applicable for lossy codecs
lossy_bitrate = 320

# Filter a Qobuz artist's discography. Set to 'true' to turn on a filter.

[filters]
# Remove Collectors Editions, live recordings, etc.
extras = false
# Picks the highest quality out of albums with identical titles.
repeats = false
# Remove EPs and Singles
non_albums = true
# Remove albums whose artist is not the one requested
features = false
# Skip non studio albums
non_studio_albums = false
# Only download remastered albums
non_remaster = false

[artwork]
# Write the image to the audio file
embed = true
# The size of the artwork to embed. Options: thumbnail, small, large, original.
# "original" images can be up to 30MB, and may fail embedding. 
# Using "large" is recommended.
size = "original"
# Both of these options limit the size of the embedded artwork. If their values
# are larger than the actual dimensions of the image, they will be ignored.
# If either value is -1, the image is left untouched.
max_width = -1
max_height = -1
# Save the cover image at the highest quality as a seperate jpg file
keep_hires_cover = true

[metadata]
# Sets the value of the 'ALBUM' field in the metadata to the playlist's name. 
# This is useful if your music library software organizes tracks based on album name.
set_playlist_to_album = true
# Replaces the original track's tracknumber with it's position in the playlist
new_playlist_tracknumbers = true
# The following metadata tags won't be applied
# See https://github.com/nathom/streamrip/wiki/Metadata-Tag-Names for more info
exclude = []

# Changes the folder and file names generated by streamrip.

[filepaths]
# Create folders for single tracks within the downloads directory using the folder_format
# template
add_singles_to_folder = false
# Available keys: "albumartist", "title", "year", "bit_depth", "sampling_rate",
# "container", "id", and "albumcomposer"
folder_format = "{albumartist} - {title} ({year}) [{container}] [{bit_depth}B-{sampling_rate}kHz]"
# Available keys: "tracknumber", "artist", "albumartist", "composer", "title",
# and "albumcomposer"
track_format = "{tracknumber}. {artist} - {title}{explicit}"
# Only allow printable ASCII characters in filenames.
restrict_characters = false

# Last.fm playlists are downloaded by searching for the titles of the tracks

[lastfm]
# The source on which to search for the tracks.
source = "qobuz"
# If no results were found with the primary source, the item is searched for 
# on this one.
fallback_source = "deezer"

[theme]
# Options: "dainty" or "plain"
progress_bar = "dainty"

[misc]
# Metadata to identify this config file. Do not change.
version = "1.9.2"

Operating System

Linux

streamrip version

1.9.5

Screenshots and recordings

No response

Additional context

No response

[irdkwmnsb]

Happened to me too.

https://github.com/nathom/streamrip/blob/2418c4e70f49117b140e52321c059edb78af706f/rip/core.py#L327 Should there really be a continue? Or the catch clause for ItemExists should be moved somewhere deeper in the recursion stack? @nathom

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[TheRealVincentVanGogh]

same issue on dev branch as of today,

I did find the issue in case anyone is still interested-- The issue is the album-level call (I think?) to download_item has no failure handling. I added a try/catch to swallow the exception with a printout saying "already downloaded album", and that monkey patch combined with the --ignore-db flag lets you download an artist while skipping over already-downloaded albums.

Problematic line here: https://github.com/nathom/streamrip/blob/42b786b7f3c76caf84d5b461619073335e5863a5/streamrip/media.py#L1998

fix:

try:
    self.download... blah blah
except:
    secho("skipping over an album", fg="yellow")

hope this helps someone!

[FrenchGithubUser]

is this going to be "fixed" in the next release ? or is it supposed to be the default behavior for some reason ?

[jv3o3]

is this going to be "fixed" in the next release ? or is it supposed to be the default behavior for some reason ?

same issue on dev branch as of today,

I did find the issue in case anyone is still interested-- The issue is the album-level call (I think?) to download_item has no failure handling. I added a try/catch to swallow the exception with a printout saying "already downloaded album", and that monkey patch combined with the --ignore-db flag lets you download an artist while skipping over already-downloaded albums.

Problematic line here:

https://github.com/nathom/streamrip/blob/42b786b7f3c76caf84d5b461619073335e5863a5/streamrip/media.py#L1998

fix:

try:
    self.download... blah blah
except:
    secho("skipping over an album", fg="yellow")

hope this helps someone!

How could one implement this? 😑

[jv3o3]

is this going to be "fixed" in the next release ? or is it supposed to be the default behavior for some reason ?

Have you figured out a solution?

[xyxzxyz]

Same issue here...

[TheRealVincentVanGogh]

To implement my fix locally, install the package as usual, locate the install folder (usually under site-packages of your python install), and then find the file called media.py, and add a try-catch on the line mentioned in my previous comment.

Let me know if you have any qs!