search

nathom / streamrip

A scriptable music downloader for Qobuz, Tidal, SoundCloud, and Deezer
GNU General Public License v3.0
2.73k stars 247 forks source link

[BUG] (Tidal) 'Video' object has no attribute 'title', even with videos disabled #347

Closed dr0idb0t closed 2 years ago

dr0idb0t commented 2 years ago

Describe the bug

Even with videos disabled, the program crashes trying to download a video because the Title is empty?

Prevents the download of MANY artists.

Command Used

rip url https://tidal.com/browse/artist/5428
rip url https://tidal.com/browse/artist/7804
rip url https://tidal.com/browse/artist/30192
rip url https://tidal.com/browse/artist/509 
rip url https://tidal.com/browse/artist/14155 
rip url https://tidal.com/browse/artist/12009 
rip url https://tidal.com/browse/artist/3604686 
rip url https://tidal.com/browse/artist/27318 
rip url https://tidal.com/browse/artist/16139

Debug Traceback

JAY-Z - Young Forever (Live) exists. Skipping.

  Stack trace:

  11  /usr/local/lib/python3.10/site-packages/cleo/application.py:330 in run
       328│
       329│             try:
     → 330│                 exit_code = self._run(io)
       331│             except Exception as e:
       332│                 if not self._catch_exceptions:

  10  /usr/local/lib/python3.10/site-packages/rip/cli.py:760 in _run
       758│             logger.addHandler(fh)
       759│
     → 760│         super()._run(io)
       761│
       762│     def create_io(self, input=None, output=None, error_output=None):

   9  /usr/local/lib/python3.10/site-packages/cleo/application.py:425 in _run
       423│                 io.set_input(ArgvInput(argv))
       424│
     → 425│         exit_code = self._run_command(command, io)
       426│         self._running_command = None
       427│

   8  /usr/local/lib/python3.10/site-packages/cleo/application.py:432 in _run_command
       430│     def _run_command(self, command: Command, io: IO) -> int:
       431│         if self._event_dispatcher is None:
     → 432│             return command.run(io)
       433│
       434│         # Bind before the console.command event,

   7  /usr/local/lib/python3.10/site-packages/cleo/commands/base_command.py:118 in run
       116│         io.input.validate()
       117│
     → 118│         status_code = self.execute(io)
       119│
       120│         if status_code is None:

   6  /usr/local/lib/python3.10/site-packages/cleo/commands/command.py:85 in execute
        83│
        84│         try:
     →  85│             return self.handle()
        86│         except KeyboardInterrupt:
        87│             return 1

   5  /usr/local/lib/python3.10/site-packages/rip/cli.py:124 in handle
       122│
       123│         if len(core) > 0:
     → 124│             core.download()
       125│         elif not urls and path is None:
       126│             self.line("Must pass arguments. See rip url -h.")

   4  /usr/local/lib/python3.10/site-packages/rip/core.py:313 in download
       311│
       312│             try:
     → 313│                 item.download(**arguments)
       314│                 for item_id in item.downloaded_ids:
       315│                     self.db.add([item_id])

   3  /usr/local/lib/python3.10/site-packages/streamrip/media.py:2008 in download
       2006│         iterator = self._prepare_download(**kwargs)
       2007│         for item in iterator:
     → 2008│             self._download_item(item, **kwargs)
       2009│
       2010│     def _load_albums(self):

   2  /usr/local/lib/python3.10/site-packages/streamrip/media.py:2094 in _download_item
       2092│         # always an Album
       2093│         try:
     → 2094│             item.download(
       2095│                 parent_folder=self.folder,
       2096│                 **kwargs,

   1  /usr/local/lib/python3.10/site-packages/streamrip/media.py:1207 in download
       1205│                     # soundcloud only gets metadata after `target` is called
       1206│                     # message will be printed in `target`
     → 1207│                     secho(f'\nDownloading "{item!s}"', bold=True, fg="green")
       1208│                 try:
       1209│                     target(item, **kwargs)

  AttributeError

  'Video' object has no attribute 'title'

  at /usr/local/lib/python3.10/site-packages/streamrip/media.py:973 in __str__
       969│         """Return the title.
       970│
       971│         :rtype: str
       972│         """
    →  973│         return self.title
       974│
       975│     def __repr__(self) -> str:
       976│         """Return a string representation of self.
       977│

If this was unexpected, please open a Bug Report at https://github.com/nathom/streamrip/issues/new/choose

Config File

[downloads]
# Folder where tracks are downloaded to
folder = "/home/xxxxx/StreamripDownloads"
# Put Qobuz albums in a 'Qobuz' folder, Tidal albums in 'Tidal' etc.
source_subdirectories = false

[downloads.concurrency]
# Download (and convert) tracks all at once, instead of sequentially. 
# If you are converting the tracks, or have fast internet, this will 
# substantially improve processing speed.
enabled = false
# The maximum number of tracks to download at once
# If you have very fast internet, you will benefit from a higher value,
# A value that is too high for your bandwidth may cause slowdowns
max_connections = 3

[qobuz]
# 1: 320kbps MP3, 2: 16/44.1, 3: 24/<=96, 4: 24/>=96
quality = 4
# This will download booklet pdfs that are included with some albums
download_booklets = true

email = "x@x.x"
# This is an md5 hash of the plaintext password
password = "x"
# Do not change
app_id = "x"
# Do not change
secrets = ["x", "x"]

[tidal]
# 0: 256kbps AAC, 1: 320kbps AAC, 2: 16/44.1 "HiFi" FLAC, 3: 24/44.1 "MQA" FLAC
quality = 3
# This will download videos included in Video Albums.
download_videos = false

# Do not change any of the fields below
user_id = x
country_code = "xx"
access_token = "xx"
refresh_token = "xx"
# Tokens last 1 week after refresh. This is the Unix timestamp of the expiration
# time. If you haven't used streamrip in more than a week, you may have to log
# in again using `rip config --tidal`
token_expiry = xx

[deezer]
# 0, 1, or 2
# This only applies to paid Deezer subscriptions. Those using deezloader
# are automatically limited to quality = 1
quality = 2
# An authentication cookie that allows streamrip to use your Deezer account
# See https://github.com/nathom/streamrip/wiki/Finding-Your-Deezer-ARL-Cookie
# for instructions on how to find this
arl = ""
# This allows for free 320kbps MP3 downloads from Deezer
# If an arl is provided, deezloader is never used
use_deezloader = true
# This warns you when the paid deezer account is not logged in and rip falls
# back to deezloader, which is unreliable
deezloader_warnings = true

[soundcloud]
# Only 0 is available for now
quality = 0
# This changes periodically, so it needs to be updated
client_id = ""
app_version = ""

[youtube]
# Only 0 is available for now
quality = 0
# Download the video along with the audio
download_videos = false
# The path to download the videos to
video_downloads_folder = ""

# This stores a list of item IDs so that repeats are not downloaded.

[database.downloads]
enabled = true
path = "/home/xx/.config/streamrip/downloads.db"

# If a download fails, the item ID is stored here. Then, `rip repair` can be
# called to retry the downloads

[database.failed_downloads]
enabled = true
path = "/home/xx/.config/streamrip/failed_downloads.db"

# Convert tracks to a codec after downloading them.

[conversion]
enabled = false
# FLAC, ALAC, OPUS, MP3, VORBIS, or AAC
codec = "ALAC"
# In Hz. Tracks are downsampled if their sampling rate is greater than this. 
# Value of 48000 is recommended to maximize quality and minimize space
sampling_rate = 48000
# Only 16 and 24 are available. It is only applied when the bit depth is higher
# than this value.
bit_depth = 24
# Only applicable for lossy codecs
lossy_bitrate = 320

# Filter a Qobuz artist's discography. Set to 'true' to turn on a filter.

[filters]
# Remove Collectors Editions, live recordings, etc.
extras = false
# Picks the highest quality out of albums with identical titles.
repeats = false
# Remove EPs and Singles
non_albums = false
# Remove albums whose artist is not the one requested
features = false
# Skip non studio albums
non_studio_albums = false
# Only download remastered albums
non_remaster = false

[artwork]
# Write the image to the audio file
embed = true
# The size of the artwork to embed. Options: thumbnail, small, large, original.
# "original" images can be up to 30MB, and may fail embedding. 
# Using "large" is recommended.
size = "large"
# Both of these options limit the size of the embedded artwork. If their values
# are larger than the actual dimensions of the image, they will be ignored.
# If either value is -1, the image is left untouched.
max_width = -1
max_height = -1
# Save the cover image at the highest quality as a seperate jpg file
keep_hires_cover = true

[metadata]
# Sets the value of the 'ALBUM' field in the metadata to the playlist's name. 
# This is useful if your music library software organizes tracks based on album name.
set_playlist_to_album = true
# Replaces the original track's tracknumber with it's position in the playlist
new_playlist_tracknumbers = true
# The following metadata tags won't be applied
# See https://github.com/nathom/streamrip/wiki/Metadata-Tag-Names for more info
exclude = []

# Changes the folder and file names generated by streamrip.

[filepaths]
# Create folders for single tracks within the downloads directory using the folder_format
# template
add_singles_to_folder = false
# Available keys: "albumartist", "title", "year", "bit_depth", "sampling_rate",
# "container", "id", and "albumcomposer"
folder_format = "{albumartist} - {title} ({year}) [{container}] [{bit_depth}B-{sampling_rate}kHz]"
# Available keys: "tracknumber", "artist", "albumartist", "composer", "title",
# and "albumcomposer"
track_format = "{tracknumber}. {artist} - {title}{explicit}"
# Only allow printable ASCII characters in filenames.
restrict_characters = false

# Last.fm playlists are downloaded by searching for the titles of the tracks

[lastfm]
# The source on which to search for the tracks.
source = "qobuz"
# If no results were found with the primary source, the item is searched for 
# on this one.
fallback_source = "deezer"

[theme]
# Options: "dainty" or "plain"
progress_bar = "dainty"

[misc]
# Metadata to identify this config file. Do not change.
version = "1.9.2"

Operating System

Debian 10 / Linux

streamrip version

1.9.5

Screenshots and recordings

No response

Additional context

No response

dr0idb0t commented 2 years ago

Still wanted to finish these downloads.

For those with this issue, and want to continue downloading full artists without patching, in streamrip/media.py line 973 change self.title to str(self.id), line 980 change self.title to str(self.id).

It'll spit out the ID for the file on Tidal then continue.

Would make a PR but I can't be arsed.

dr0idb0t commented 2 years ago

Nvm - didn't mean to close.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.