nathom / streamrip

A scriptable music downloader for Qobuz, Tidal, SoundCloud, and Deezer
GNU General Public License v3.0
2.66k stars 234 forks source link

Impossible to convert to MP3 #454

Closed Aubinebn closed 1 year ago

Aubinebn commented 1 year ago

Describe the bug

I am having trouble when i try to convert FLAC tracks to MP3 Thank's for your help

Command Used

rip convert MP3 /Users/aubin/Documents/Perso/01.\ Trap\ Manny\ -\ 50k\ \(feat.\ Pop\ Smoke\).flac -vvv

Debug Traceback

DEBUG:streamrip:{'self': <streamrip.converter.LAME object at 0x10e3d0410>, 'filename': '/Users/aubin/Documents/Perso/01. Trap Manny - 50k (feat. Pop Smoke).flac', 'ffmpeg_arg': None, 'sampling_rate': 192000, 'bit_depth': 24, 'copy_art': True, 'remove_source': True, 'show_progress': False}
DEBUG:streamrip:No arguments provided. Codec defaults will be used
DEBUG:streamrip:FFmpeg codec extra argument: -q:a 0
DEBUG:streamrip:['ffmpeg', '-i', '/Users/aubin/Documents/Perso/01. Trap Manny - 50k (feat. Pop Smoke).flac', '-c:a', 'libmp3lame', '-c:v', 'copy', '-q:a', '0', '-y', '/var/folders/wx/cqtdbtj96f96fqbn9bsm5nj80000gn/T/01. Trap Manny - 50k (feat. Pop Smoke).mp3']
DEBUG:streamrip:Generated conversion command: ['ffmpeg', '-i', '/Users/aubin/Documents/Perso/01. Trap Manny - 50k (feat. Pop Smoke).flac', '-c:a', 'libmp3lame', '-c:v', 'copy', '-q:a', '0', '-y', '/var/folders/wx/cqtdbtj96f96fqbn9bsm5nj80000gn/T/01. Trap Manny - 50k (feat. Pop Smoke).mp3']

  Stack trace:

  9  /usr/local/lib/python3.11/site-packages/cleo/application.py:330 in run
      328│ 
      329│             try:
    → 330│                 exit_code = self._run(io)
      331│             except Exception as e:
      332│                 if not self._catch_exceptions:

  8  /usr/local/lib/python3.11/site-packages/rip/cli.py:762 in _run
      760│             logger.addHandler(fh)
      761│ 
    → 762│         super()._run(io)
      763│ 
      764│     def create_io(self, input=None, output=None, error_output=None):

  7  /usr/local/lib/python3.11/site-packages/cleo/application.py:425 in _run
      423│                 io.set_input(ArgvInput(argv))
      424│ 
    → 425│         exit_code = self._run_command(command, io)
      426│         self._running_command = None
      427│ 

  6  /usr/local/lib/python3.11/site-packages/cleo/application.py:432 in _run_command
      430│     def _run_command(self, command: Command, io: IO) -> int:
      431│         if self._event_dispatcher is None:
    → 432│             return command.run(io)
      433│ 
      434│         # Bind before the console.command event,

  5  /usr/local/lib/python3.11/site-packages/cleo/commands/base_command.py:118 in run
      116│         io.input.validate()
      117│ 
    → 118│         status_code = self.execute(io)
      119│ 
      120│         if status_code is None:

  4  /usr/local/lib/python3.11/site-packages/cleo/commands/command.py:85 in execute
       83│ 
       84│         try:
    →  85│             return self.handle()
       86│         except KeyboardInterrupt:
       87│             return 1

  3  /usr/local/lib/python3.11/site-packages/rip/cli.py:650 in handle
      648│ 
      649│         elif os.path.isfile(path):
    → 650│             ConverterCls(filename=path, **converter_args).convert()
      651│         else:
      652│             self.line(

  2  /usr/local/lib/python3.11/site-packages/streamrip/converter.py:84 in convert
       82│         logger.debug("Generated conversion command: %s", self.command)
       83│ 
    →  84│         process = subprocess.Popen(self.command, stderr=subprocess.PIPE)
       85│         process.wait()
       86│         if process.returncode == 0 and os.path.isfile(self.tempfile):

  1  /usr/local/Cellar/python@3.11/3.11.4_1/Frameworks/Python.framework/Versions/3.11/lib/python3.11/subprocess.py:1026 in __init__
      1024│                             encoding=encoding, errors=errors)
      1025│ 
    → 1026│             self._execute_child(args, executable, preexec_fn, close_fds,
      1027│                                 pass_fds, cwd, env,
      1028│                                 startupinfo, creationflags, shell,

  FileNotFoundError

  [Errno 2] No such file or directory: 'ffmpeg'

  at /usr/local/Cellar/python@3.11/3.11.4_1/Frameworks/Python.framework/Versions/3.11/lib/python3.11/subprocess.py:1950 in _execute_child
      1946│                     else:
      1947│                         err_filename = orig_executable
      1948│                     if errno_num != 0:
      1949│                         err_msg = os.strerror(errno_num)
    → 1950│                     raise child_exception_type(errno_num, err_msg, err_filename)
      1951│                 raise child_exception_type(err_msg)
      1952│ 
      1953│ 
      1954│         def _handle_exitstatus(self, sts,

Config File

[downloads]
# Folder where tracks are downloaded to
folder = "/Users/aubin/Documents/Perso/Musique"
# Put Qobuz albums in a 'Qobuz' folder, Tidal albums in 'Tidal' etc.
source_subdirectories = false

[downloads.concurrency]
# Download (and convert) tracks all at once, instead of sequentially. 
# If you are converting the tracks, or have fast internet, this will 
# substantially improve processing speed.
enabled = true
# The maximum number of tracks to download at once
# If you have very fast internet, you will benefit from a higher value,
# A value that is too high for your bandwidth may cause slowdowns
max_connections = 3

[qobuz]
# 1: 320kbps MP3, 2: 16/44.1, 3: 24/<=96, 4: 24/>=96
quality = 3
# This will download booklet pdfs that are included with some albums
download_booklets = true

email = ""
# This is an md5 hash of the plaintext password
password = ""
# Do not change
app_id = ""
# Do not change
secrets = []

[tidal]
# 0: 256kbps AAC, 1: 320kbps AAC, 2: 16/44.1 "HiFi" FLAC, 3: 24/44.1 "MQA" FLAC
quality = 3
# This will download videos included in Video Albums.
download_videos = true

# Do not change any of the fields below
user_id = ""
country_code = ""
access_token = ""
refresh_token = ""
# Tokens last 1 week after refresh. This is the Unix timestamp of the expiration
# time. If you haven't used streamrip in more than a week, you may have to log
# in again using `rip config --tidal`
token_expiry = ""

[deezer]
# 0, 1, or 2
# This only applies to paid Deezer subscriptions. Those using deezloader
# are automatically limited to quality = 1
quality = 2
# An authentication cookie that allows streamrip to use your Deezer account
# See https://github.com/nathom/streamrip/wiki/Finding-Your-Deezer-ARL-Cookie
# for instructions on how to find this
arl = "HIDDEN"
# This allows for free 320kbps MP3 downloads from Deezer
# If an arl is provided, deezloader is never used
use_deezloader = true
# This warns you when the paid deezer account is not logged in and rip falls
# back to deezloader, which is unreliable
deezloader_warnings = true

[soundcloud]
# Only 0 is available for now
quality = 0
# This changes periodically, so it needs to be updated
client_id = ""
app_version = ""

[youtube]
# Only 0 is available for now
quality = 0
# Download the video along with the audio
download_videos = false
# The path to download the videos to
video_downloads_folder = ""

# This stores a list of item IDs so that repeats are not downloaded.

[database.downloads]
enabled = true
path = "/Users/aubin/Library/Application Support/streamrip/downloads.db"

# If a download fails, the item ID is stored here. Then, `rip repair` can be
# called to retry the downloads

[database.failed_downloads]
enabled = false
path = "/Users/aubin/Library/Application Support/streamrip/failed_downloads.db"

# Convert tracks to a codec after downloading them.

[conversion]
enabled = false
# FLAC, ALAC, OPUS, MP3, VORBIS, or AAC
codec = "MP3"
# In Hz. Tracks are downsampled if their sampling rate is greater than this. 
# Value of 48000 is recommended to maximize quality and minimize space
sampling_rate = 48000
# Only 16 and 24 are available. It is only applied when the bit depth is higher
# than this value.
bit_depth = 24
# Only applicable for lossy codecs
lossy_bitrate = 320

# Filter a Qobuz artist's discography. Set to 'true' to turn on a filter.

[filters]
# Remove Collectors Editions, live recordings, etc.
extras = false
# Picks the highest quality out of albums with identical titles.
repeats = false
# Remove EPs and Singles
non_albums = false
# Remove albums whose artist is not the one requested
features = false
# Skip non studio albums
non_studio_albums = false
# Only download remastered albums
non_remaster = false

[artwork]
# Write the image to the audio file
embed = true
# The size of the artwork to embed. Options: thumbnail, small, large, original.
# "original" images can be up to 30MB, and may fail embedding. 
# Using "large" is recommended.
size = "large"
# Both of these options limit the size of the embedded artwork. If their values
# are larger than the actual dimensions of the image, they will be ignored.
# If either value is -1, the image is left untouched.
max_width = -1
max_height = -1
# Save the cover image at the highest quality as a seperate jpg file
keep_hires_cover = true

[metadata]
# Sets the value of the 'ALBUM' field in the metadata to the playlist's name. 
# This is useful if your music library software organizes tracks based on album name.
set_playlist_to_album = true
# Replaces the original track's tracknumber with it's position in the playlist
new_playlist_tracknumbers = true
# The following metadata tags won't be applied
# See https://github.com/nathom/streamrip/wiki/Metadata-Tag-Names for more info
exclude = []

# Changes the folder and file names generated by streamrip.

[filepaths]
# Create folders for single tracks within the downloads directory using the folder_format
# template
add_singles_to_folder = false
# Available keys: "albumartist", "title", "year", "bit_depth", "sampling_rate",
# "container", "id", and "albumcomposer"
folder_format = "{albumartist} - {title}"
# Available keys: "tracknumber", "artist", "albumartist", "composer", "title",
# and "albumcomposer"
track_format = "{tracknumber}. {artist} - {title}{explicit}"
# Only allow printable ASCII characters in filenames.
restrict_characters = false
# Truncate the filename if it is greater than 120 characters
# Setting this to false may cause downloads to fail on some systems
truncate = true

# Last.fm playlists are downloaded by searching for the titles of the tracks

[lastfm]
# The source on which to search for the tracks.
source = "qobuz"
# If no results were found with the primary source, the item is searched for 
# on this one.
fallback_source = "deezer"

[theme]
# Options: "dainty" or "plain"
progress_bar = "plain"

[misc]
# Metadata to identify this config file. Do not change.
version = "1.9.6"

Operating System

MAC OS 13.2.1 on Apple M2

streamrip version

1.9.7

Screenshots and recordings

No response

Additional context

It seems to be an issue about convert in a global way because the results of rip url -c MP3 "deezer url" are .flac files.

nathom commented 1 year ago

You need to install ffmpeg.

Aubinebn commented 1 year ago

Thank you