Closed Tom4tot closed 7 months ago
Same problem as well. There's album that have characters such as "?" and since Windows doesn't allow "?" to be renamed on Folders. Suddenly, streamrip decides to not download it.
Yes, same here, Hoping for an update to ignore these characters since windows doesn't like them on folders!
Same issue on WSL
Track 6 ━━━━╸━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.9% • 1.7 MB/s • 0:00:22
Track 18 ━━━━━╸━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 2.4% • 1.8 MB/s • 0:00:16
Track 13 ━━━━━╺━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 2.0% • 1.8 MB/s • 0:00:14
╭─────────────────────────────── Traceback (most recent call last) ────────────────────────────────╮
│ /home/snucker/.local/bin/rip:8 in <module> │
│ │
│ 5 from streamrip.rip import rip │
│ 6 if __name__ == '__main__': │
│ 7 │ sys.argv[0] = re.sub(r'(-script\.pyw|\.exe)?$', '', sys.argv[0]) │
│ ❱ 8 │ sys.exit(rip()) │
│ 9 │
│ │
│ /home/snucker/.local/lib/python3.10/site-packages/click/core.py:1157 in __call__ │
│ │
│ ... 19 frames hidden ... │
│ │
│ /home/snucker/.local/lib/python3.10/site-packages/streamrip/metadata/track.py:55 in from_qobuz │
│ │
│ 52 │ │ composer = typed(resp.get("composer", {}).get("name"), str | None) │
│ 53 │ │ tracknumber = typed(resp.get("track_number", 1), int) │
│ 54 │ │ discnumber = typed(resp.get("media_number", 1), int) │
│ ❱ 55 │ │ artist = typed( │
│ 56 │ │ │ safe_get( │
│ 57 │ │ │ │ resp, │
│ 58 │ │ │ │ "performer", │
│ │
│ /home/snucker/.local/lib/python3.10/site-packages/streamrip/metadata/util.py:24 in typed │
│ │
│ 21 │
│ 22 │
│ 23 def typed(thing, expected_type: Type[T]) -> T: │
│ ❱ 24 │ assert isinstance(thing, expected_type) │
│ 25 │ return thing │
│ 26 │
│ 27 │
╰──────────────────────────────────────────────────────────────────────────────────────────────────╯
AssertionError
sys:1: RuntimeWarning: coroutine 'Artist._download_async.<locals>._rip' was never awaited
rip --version
rip, version 2.0.3```
@herovaxy @NighthawkUK @snucker-fod fixed in v2.0.3
Describe the bug
Hi,
in my config, my albums are downloaded this way:
It mostly works, however, I tried to download an album that has ":" in its title, and it didn't work (in my case, it's Codename: Dustsucker)
Here is the message I got:
If I change my config file so the album title is not included, the album is downloaded normally.
Streamrip should ignore/replace reserved characters (you can find the list here: https://learn.microsoft.com/en-us/windows/win32/fileio/naming-a-file ) < (less than)
Command Used
Debug Traceback
Config File
Operating System
Windows 11
streamrip version
2.0.2
Screenshots and recordings
No response
Additional context
No response