[BUG] Unable to download artists or albums, only singles

snucker-fod commented 8 months ago

Describe the bug

Unable to download artists or albums, only singles.

Command Used

rip url https://play.qobuz.com/artist/71833
rip url https://play.qobuz.com/album/e35h0w5722w6a

Debug Traceback

╭─────────────────────────────── Traceback (most recent call last) ────────────────────────────────╮
│ /home/snucker/.local/bin/rip:8 in <module>                                                       │
│                                                                                                  │
│   5 from streamrip.rip import rip                                                                │
│   6 if __name__ == '__main__':                                                                   │
│   7 │   sys.argv[0] = re.sub(r'(-script\.pyw|\.exe)?$', '', sys.argv[0])                         │
│ ❱ 8 │   sys.exit(rip())                                                                          │
│   9                                                                                              │
│                                                                                                  │
│ /home/snucker/.local/lib/python3.10/site-packages/click/core.py:1157 in __call__                 │
│                                                                                                  │
│                                     ... 15 frames hidden ...                                     │
│                                                                                                  │
│ /home/snucker/.local/lib/python3.10/site-packages/streamrip/media/album.py:92 in _album_folder   │
│                                                                                                  │
│   89 │   │   if config.downloads.source_subdirectories:                                          │
│   90 │   │   │   parent = os.path.join(parent, self.client.source.capitalize())                  │
│   91 │   │   formatter = config.filepaths.folder_format                                          │
│ ❱ 92 │   │   folder = clean_filepath(                                                            │
│   93 │   │   │   meta.format_folder_path(formatter), config.filepaths.restrict_characters        │
│   94 │   │   )                                                                                   │
│   95                                                                                             │
│                                                                                                  │
│ /home/snucker/.local/lib/python3.10/site-packages/streamrip/filepath_utils.py:16 in              │
│ clean_filepath                                                                                   │
│                                                                                                  │
│   13 │   return path                                                                             │
│   14                                                                                             │
│   15 def clean_filepath(fn: str, restrict: bool = False) -> str:                                 │
│ ❱ 16 │   path = str(sanitize_filepath(fn))                                                       │
│   17 │   if restrict:                                                                            │
│   18 │   │   path = "".join(c for c in path if c in ALLOWED_CHARS)                               │
│   19                                                                                             │
╰──────────────────────────────────────────────────────────────────────────────────────────────────╯
NameError: name 'sanitize_filepath' is not defined
sys:1: RuntimeWarning: coroutine 'Artist._download_async.<locals>._rip' was never awaited

Config File

[downloads]
# Folder where tracks are downloaded to
folder = "/home/snucker/StreamripDownloads"
# Put Qobuz albums in a 'Qobuz' folder, Tidal albums in 'Tidal' etc.
source_subdirectories = false

# Download (and convert) tracks all at once, instead of sequentially. 
# If you are converting the tracks, or have fast internet, this will 
# substantially improve processing speed.
concurrency = true
# The maximum number of tracks to download at once
# If you have very fast internet, you will benefit from a higher value,
# A value that is too high for your bandwidth may cause slowdowns
# Set to -1 for no limit
max_connections = 6
# Max number of API requests per source to handle per minute
# Set to -1 for no limit
requests_per_minute = 60

[qobuz]
# 1: 320kbps MP3, 2: 16/44.1, 3: 24/<=96, 4: 24/>=96
quality = 2
# This will download booklet pdfs that are included with some albums
download_booklets = true

# Authenticate to Qobuz using auth token? Value can be true/false only
use_auth_token = false
# Enter your userid if the above use_auth_token is set to true, else enter your email
email_or_userid = ""
# Enter your auth token if the above use_auth_token is set to true, else enter the md5 hash of your plaintext password
password_or_token = ""
# Do not change
app_id = ""
# Do not change
secrets = []

[tidal]
# 0: 256kbps AAC, 1: 320kbps AAC, 2: 16/44.1 "HiFi" FLAC, 3: 24/44.1 "MQA" FLAC
quality = 2
# This will download videos included in Video Albums.
download_videos = true

# Do not change any of the fields below
user_id = ""
country_code = ""
access_token = ""
refresh_token = ""
# Tokens last 1 week after refresh. This is the Unix timestamp of the expiration
# time. If you haven't used streamrip in more than a week, you may have to log
# in again using `rip config --tidal`
token_expiry = ""

[deezer]
# 0, 1, or 2
# This only applies to paid Deezer subscriptions. Those using deezloader
# are automatically limited to quality = 1
quality = 2
# An authentication cookie that allows streamrip to use your Deezer account
# See https://github.com/nathom/streamrip/wiki/Finding-Your-Deezer-ARL-Cookie
# for instructions on how to find this
arl = ""
# This allows for free 320kbps MP3 downloads from Deezer
# If an arl is provided, deezloader is never used
use_deezloader = true
# This warns you when the paid deezer account is not logged in and rip falls
# back to deezloader, which is unreliable
deezloader_warnings = true

[soundcloud]
# Only 0 is available for now
quality = 0
# This changes periodically, so it needs to be updated
client_id = ""
app_version = ""

[youtube]
# Only 0 is available for now
quality = 0
# Download the video along with the audio
download_videos = false
# The path to download the videos to
video_downloads_folder = "/home/snucker/StreamripDownloads/YouTubeVideos"

[database]
# Create a database that contains all the track IDs downloaded so far
# Any time a track logged in the database is requested, it is skipped
# This can be disabled temporarily with the --no-db flag
downloads_enabled = true
# Path to the downloads database 
downloads_path = "/home/snucker/.config/streamrip/downloads.db"
# If a download fails, the item ID is stored here. Then, `rip repair` can be
# called to retry the downloads
failed_downloads_enabled = true
failed_downloads_path = "/home/snucker/.config/streamrip/failed_downloads.db"

# Convert tracks to a codec after downloading them.
[conversion]
enabled = false
# FLAC, ALAC, OPUS, MP3, VORBIS, or AAC
codec = "FLAC"
# In Hz. Tracks are downsampled if their sampling rate is greater than this. 
# Value of 48000 is recommended to maximize quality and minimize space
sampling_rate = 48000
# Only 16 and 24 are available. It is only applied when the bit depth is higher
# than this value.
bit_depth = 16
# Only applicable for lossy codecs
lossy_bitrate = 320

# Filter a Qobuz artist's discography. Set to 'true' to turn on a filter.
# This will also be applied to other sources, but is not guaranteed to work correctly
[qobuz_filters]
# Remove Collectors Editions, live recordings, etc.
extras = false
# Picks the highest quality out of albums with identical titles.
repeats = false
# Remove EPs and Singles
non_albums = false
# Remove albums whose artist is not the one requested
features = false
# Skip non studio albums
non_studio_albums = false
# Only download remastered albums
non_remaster = false

[artwork]
# Write the image to the audio file
embed = true
# The size of the artwork to embed. Options: thumbnail, small, large, original.
# "original" images can be up to 30MB, and may fail embedding. 
# Using "large" is recommended.
embed_size = "large"
# If this is set to a value > 0, max(width, height) of the embedded art will be set to this value in pixels
# Proportions of the image will remain the same
embed_max_width = -1
# Save the cover image at the highest quality as a seperate jpg file
save_artwork = true
# If this is set to a value > 0, max(width, height) of the saved art will be set to this value in pixels
# Proportions of the image will remain the same
saved_max_width = -1

[metadata]
# Sets the value of the 'ALBUM' field in the metadata to the playlist's name. 
# This is useful if your music library software organizes tracks based on album name.
set_playlist_to_album = true
# If part of a playlist, sets the `tracknumber` field in the metadata to the track's 
# position in the playlist instead of its position in its album
renumber_playlist_tracks = true
# The following metadata tags won't be applied
# See https://github.com/nathom/streamrip/wiki/Metadata-Tag-Names for more info
exclude = []

# Changes the folder and file names generated by streamrip.
[filepaths]
# Create folders for single tracks within the downloads directory using the folder_format
# template
add_singles_to_folder = false
# Available keys: "albumartist", "title", "year", "bit_depth", "sampling_rate",
# "id", and "albumcomposer"
folder_format = "{albumartist} - {title} ({year}) [{container}] [{bit_depth}B-{sampling_rate}kHz]"
# folder_format = "{albumartist} - {title} ({year})"
# Available keys: "tracknumber", "artist", "albumartist", "composer", "title",
# and "albumcomposer", "explicit"
track_format = "{tracknumber}. {artist} - {title}{explicit}"
# Only allow printable ASCII characters in filenames.
restrict_characters = true
# Truncate the filename if it is greater than this number of characters
# Setting this to false may cause downloads to fail on some systems
truncate_to = 120

# Last.fm playlists are downloaded by searching for the titles of the tracks
[lastfm]
# The source on which to search for the tracks.
source = "qobuz"
# If no results were found with the primary source, the item is searched for 
# on this one.
fallback_source = ""

[cli]
# Print "Downloading {Album name}" etc. to screen
text_output = true
# Show resolve, download progress bars
progress_bars = true
# The maximum number of search results to show in the interactive menu
max_search_results = 100

[misc]
# Metadata to identify this config file. Do not change.
version = "2.0.3"
# Print a message if a new version of streamrip is available 
check_for_updates = true

Operating System

Linux 5.15.133.1-microsoft-standard-WSL2 x86_64

streamrip version

rip, version 2.0.4

Screenshots and recordings

No response

Additional context

No response

korb3n commented 8 months ago

I'm on Windows and as a temporary fix i've added: from pathvalidate import sanitize_filepath in filepath_utils.py

matthewhm commented 8 months ago

I have the same issue as snucker-fod. I have tried your fix korb3n on Ubuntu Studio 22.04 but now I am getting AssertionError ╭─────────────────────────────── Traceback (most recent call last) ────────────────────────────────╮ │ /home/matthew/.local/bin/rip:8 in │ │ │ │ 5 from streamrip.rip import rip │ │ 6 if name == 'main': │ │ 7 │ sys.argv[0] = re.sub(r'(-script.pyw|.exe)?$', '', sys.argv[0]) │ │ ❱ 8 │ sys.exit(rip()) │ │ 9 │ │ │ │ /usr/lib/python3/dist-packages/click/core.py:1128 in call │ │ │ │ ... 15 frames hidden ... │ │ │ │ /home/matthew/.local/lib/python3.10/site-packages/streamrip/metadata/track.py:55 in from_qobuz │ │ │ │ 52 │ │ composer = typed(resp.get("composer", {}).get("name"), str | None) │ │ 53 │ │ tracknumber = typed(resp.get("track_number", 1), int) │ │ 54 │ │ discnumber = typed(resp.get("media_number", 1), int) │ │ ❱ 55 │ │ artist = typed( │ │ 56 │ │ │ safe_get( │ │ 57 │ │ │ │ resp, │ │ 58 │ │ │ │ "performer", │ │ │ │ /home/matthew/.local/lib/python3.10/site-packages/streamrip/metadata/util.py:24 in typed │ │ │ │ 21 │ │ 22 │ │ 23 def typed(thing, expected_type: Type[T]) -> T: │ │ ❱ 24 │ assert isinstance(thing, expected_type) │ │ 25 │ return thing │ │ 26 │ │ 27 │ ╰──────────────────────────────────────────────────────────────────────────────────────────────────╯ AssertionError

korb3n commented 8 months ago

I don't know but a version 2.0.5 has been released since so maybe give it a try.

matthewhm commented 8 months ago

Thank you korb3n. I have reinstalled 2.0.5 and updated pip and it seems to be working without errors again.

snucker-fod commented 8 months ago

Fixed as of 2.0.5

nathom / streamrip