Closed slanglade closed 4 weeks ago
Warning, there is a breaking change : the "downloaded.db" table contains a new column. So users need to delete their old table
This needs to be split into multiple PRs so that I can review.
Hi @nathom ,
I can cancel and create another PR for the first part (it's the end state of my first branch), with all that is required to deal with playlist for all sources :
It also contains the supression of some fatal exceptions when dealing with Deezer :
The changes related to tracks are scattered accross 12 files. I can add a db DDL update to avoid breaking change, except when activating m3u8 file generation who would force the track to be fully re-downloaded.
Then I will create another one for the handling of alternative deezer track in playlist, when the original one is not readable.
Is it ok for you ?
Or I can move the fix for Deezer errors (FLAC not recognized, max bitrate undefined) to the second part with alternative Deezer tracks, by juggling a bit with my two branches.
Yes any way is fine. But each one should be one feature or in one category. The breaking DB change needs to be separate for sure.
PR closed, reworking to split features
Playlist management:
Deezer alternative tracks:
Unreadable track is often due to track id changing or track not available anymore in a specific area. The latter may not be recoverable by alternative field or search. No idea why deezer is doing the former, and the Web UI or mobile app are automagically dealing with these obsolete IDs without updating the playlist content, which is a shame.
Deezer errors