nathom / streamrip

A scriptable music downloader for Qobuz, Tidal, SoundCloud, and Deezer
GNU General Public License v3.0
2.34k stars 209 forks source link

Deezer alternative track #700

Open slanglade opened 3 weeks ago

slanglade commented 3 weeks ago

Track IDs on deezer are updated quite frequently, because of some obscure track duplication. And the old version is not playable anymore. When you listen to a playlist, it contains the old identifiers, but you don't notice because the deezer interface manages to retrieve the new track version anyway.

But when streamrip retrieves the track list from a playlist, it ends up with the wrong identifiers.

This PR covers the modifications made to get around the problem (#638), in the following order of preference:

During this process, log messages are sent to the console (WARNING if alternative found, ERROR if no alternative is found).

nathom commented 3 weeks ago

Thanks. Can you make sure the ruff checks pass?

slanglade commented 3 weeks ago

Ah, nice, didn't notice the ruff tests yelling at me 😄. Ok, done

slanglade commented 3 weeks ago

I don't understand the meaning of ruff's test result, which is rather cryptic. I understand that it complains about file formatting, but i don't know what is expected. Can you give me a hint ?

nathom commented 3 weeks ago

Run ruff format

nathom commented 3 weeks ago

Ok I fixed formatting and some minor issues. Can you verify that it still works with the broken track URL? Also, can you please provide the URL that doesn't work here for the record?