natintosh / intl_phone_number_input

MIT License
163 stars 490 forks source link

feat(TextFormField): expose param inputFormatters #389

Closed hieuptc closed 1 year ago

hieuptc commented 1 year ago
FarhanSyedain commented 1 year ago

LGTM. However don't update the sdk yet,

FarhanSyedain commented 1 year ago

Closing the request for these reasons: Too many changes in one commit. A single commit is contributing to the change of the SDK. Assigning default values to some variables. As well as the main commit.

Please submit a new PR and only change the inputFormatters

Also , assign default inputFormatters too, we don't want the people to go through an extra step. Also, in my opinion input formaters should't be exposed in the first place.