search

natintosh / intl_phone_number_input

MIT License
163 stars 490 forks source link

Safe area for bottom sheet country selector list #400

Closed MDikkii closed 1 year ago

MDikkii commented 1 year ago

In the current lib version, there isn't any way to let the bottom_sheet country selector enable useSafeArea, making it unusable on mobile as the bottom sheet will go under the system bar. You can see in the video how the example is behaving on the iOS simulator.

https://github.com/natintosh/intl_phone_number_input/assets/6149761/be308d10-a4c2-451a-b454-99fbea025029

After my changes, it will be configurable from SelectorConfig. Not sure if we need it really configurable or it can be true always. But as it is not configurable at all and it is not used I would stick to making it configurable to make sure that we have backward compatibility - this config property will be set to false by default.

Please see the video after changes:

https://github.com/natintosh/intl_phone_number_input/assets/6149761/fe185c6e-767e-4f55-9d08-1aff7f71af90

It would close also 2 issues reported for some time #285 and #220

MDikkii commented 1 year ago

@FarhanSyedain, do you know how often the collaborators look into PRs and how often the new version is released?

FarhanSyedain commented 1 year ago

@FarhanSyedain, do you know how often the collaborators look into PRs and how often the new version is released?

I don't think that often. The owner himself is busy according to some of his comments.

FarhanSyedain commented 1 year ago

LGTM. Merging