Core and Platforms - Updated for latest libnx and fixed compile error

[EmmmaTech]

This is identical to #164 except an additional compile error was fixed.

[DarkMatterCore]

(for the record, my PR is for the legacy branch)

[natinusala]

Thanks for the PR! Why change the optional include? I'm not fan of changing external code like that

Le 11 août 2021 09:53:07 Pablo Curiel @.***> a écrit :

(for the record, my PR is for the legacy branch) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

[EmmmaTech]

I think I took it from somewhere else, I'll revert the change and put the optional header on top of the <nanovg/dk_renderer.hpp> header.

[EmmmaTech]

Actually, that doesn't fix it. If you compile the code, you'll get this error:

In file included from /Users/emreterzioglu/Documents/C++_Programs/borealis-fork/working-yoga/./library/lib/extern/nanovg-deko3d/source/dk_renderer.cpp:1:
/Users/emreterzioglu/Documents/C++_Programs/borealis-fork/working-yoga/./library/lib/extern/nanovg-deko3d/include/nanovg/dk_renderer.hpp:168:18: 
error: 'optional' in namespace 'std' does not name a template type
  168 |             std::optional<CMemPool::Handle> m_vertex_buffer;
      |                  ^~~~~~~~

This means the optional include has to be moved into the dk_renderer.hpp file.

[EmmmaTech]

I decided to open an issue in the nanovg-deko3d repo about this compiler error.

[EmmmaTech]

Alright, so a fix was merged into nanovg-deko3d, so I can pull the change

[JSH32]

Any plans to merge the fix? Compile error still present and I'm not able to include as a submodule because of it

[EmmmaTech]

I'm awaiting review from @natinusala They have been inactive in this repo, so PRs aren't really being reviewed.