search

natinusala / borealis

Hardware accelerated, controller and TV oriented UI library for PC and Nintendo Switch (libnx)
Apache License 2.0
254 stars 81 forks source link

Describable mixin #170

Closed maxnatamo closed 8 months ago

maxnatamo commented 2 years ago

Fixes #158

Also, excuse the typo in the commit message.

natinusala commented 2 years ago

Hello, thanks for the PR!

What you did is an interface, not a mixin.

Also for the commit message can you please reword it? Thanks

maxnatamo commented 2 years ago

I've amended the commit. Whether an interface is fine or it has to be a mixin, is up to you.

natinusala commented 2 years ago

The point is to do a mixin, not an interface :P

Le 26 octobre 2021 18:47:23 Max @.***> a écrit :

I've amended the commit. Whether an interface is fine or it has to be a mixin, is up to you. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

EmreTech commented 2 years ago

Alright, so, I recommend you search up what a mixin is before you make this PR. It's not just an inherited class, it's a lot more.

Edit: I searched on Google, and found this, which contains many examples and definitions for mixins: https://stackoverflow.com/questions/533631/what-is-a-mixin-and-why-are-they-useful