search

natinusala / borealis

Hardware accelerated, controller and TV oriented UI library for PC and Nintendo Switch (libnx)
Apache License 2.0
267 stars 84 forks source link

Add description parameter to SelectListItem constructor #47

Closed TheLukeGuy closed 4 years ago

TheLukeGuy commented 4 years ago

All of the list item types have a description parameter in their constructors except for SelectListItem, so I added it to SelectListItem to ensure consistency and obviously make it easier to add a description to a SelectListItem.

natinusala commented 4 years ago

Thanks for the PR!

How do they look in the app? It shouldn't change anything but I just want to make sure it doesn't break something visually

TheLukeGuy commented 4 years ago

I checked and everything looks fine, it behaves just like descriptions behave with other list item types!

natinusala commented 4 years ago

Okay great!