search

natinusala / borealis

Hardware accelerated, controller and TV oriented UI library for PC and Nintendo Switch (libnx)
Apache License 2.0
260 stars 83 forks source link

Fix visual overflowing of sidebar items #48

Closed Jpe230 closed 3 years ago

Jpe230 commented 4 years ago

Adding more than 7 items to the sidebar results in the remaining items to be visually overflowed past the viewbox

This PR serves two functions:

  1. Fix the overflowing of items by using ListView as the base class for the Sidebar View
  2. Incorporate LayerView in TabFrame to take advantages of the animations
natinusala commented 4 years ago

Thanks for the PR!

I didn't read all the way through yet because there are things I want to clarify first, that may require some refactoring on your end. Check out my comments on the code 😄

Also there is one thing I don't like, it's that it creates a coupling between Sidebar and TabFrame. What would you think of turning that associatedViewId (in SidebarItem) into a generic "user data" pointer? That way, Sidebar can still be used with something else than TabFrame.

Jpe230 commented 4 years ago

Hope you like it 👍

natinusala commented 4 years ago

Can you resolve the conflicts please?

natinusala commented 3 years ago

Sorry for the delay! I will be closing this PR as I don't accept contributions for master anymore, and the issue has been independently fixed in the rework branch.