Allow ListItem to use View types as thumbnails.

natinusala / borealis

Hardware accelerated, controller and TV oriented UI library for PC and Nintendo Switch (libnx)

Apache License 2.0

260 stars 83 forks source link

Allow ListItem to use View types as thumbnails. #55

Closed meganukebmp closed 3 years ago

meganukebmp commented 4 years ago

This change allows the use of View items as thumbnails while still preserving all previous functionality, as to not break anything that might depend on this.

There is some ugliness in my opinion to how I did this, mainly the dynamic casts and some repetition, but I feel as this is the cleanest way to do things. Rather have a few lines of clear repetition than a convoluted interlinking mess.

Attached is a testing application main.txt

natinusala commented 3 years ago

Thanks for the PR! Very sorry for the delay.

Unfortunately I am rewriting the library and I don't accept contributions for the master branch anymore, which will soon become legacy.

The rework does not have ListItem reimplemented yet so I cannot port your changes either... I will have another look when this is done.