nation3 / citizen-app

Nation3 citizen app
https://app.nation3.org
GNU General Public License v3.0
39 stars 39 forks source link

Remove revokeUnderBalance from config #229

Closed amochuko closed 8 months ago

amochuko commented 8 months ago

Dework Task

https://app.dework.xyz/nation3/open-bounties-95838?source=discord-dm&taskId=07770dc2-1903-4b46-8a94-70d408845e86

Related GitHub Issue

Remove nationPassportRevokeUnderBalance from config #226

Screenshots (if appropriate):

Screenshot 2024-01-20 at 05 24 06

How Has This Been Tested?

I got it tested locally while connected to the goerli testnet; here's the tx hash to the claim function: https://goerli.etherscan.io/tx/0x88ff2841554d3682eca66a539658a37a69a90984e7404953a6d77db452d6a4d0

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2024 4:32am
codecov-commenter commented 8 months ago

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (410d849) 11.17% compared to head (1bbb1c9) 11.17%.

Files Patch % Lines
ui/lib/passport-expiration-hook.ts 0.00% 10 Missing and 1 partial :warning:
ui/lib/config.ts 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #229 +/- ## ======================================= Coverage 11.17% 11.17% ======================================= Files 18 18 Lines 349 349 Branches 78 78 ======================================= Hits 39 39 Misses 304 304 Partials 6 6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

aahna-ashina commented 8 months ago

Fixed in https://github.com/nation3/app/pull/227