nation3 / mobile-passport

Take your Nation3 passport everywhere

mobile-passport.vercel.app

GNU General Public License v3.0

5 stars 7 forks source link

Apple Wallet: Send Notification Requests to APNs (#78) #79

Closed aahna-ashina closed 2 years ago

aahna-ashina commented 2 years ago

Send notification requests to Apple Push Notification service (APNs)

North Star Metric: Number of Active Citizens

Current metric: 12.43% of the 177 citizens voted on the last proposal.
Theory: Sending Nation3 updates to a citizen's Apple Wallet Pass when a new proposal is published will increase voting activity by at least 20%.

Dework Task

https://app.dework.xyz/nation3/app-2?taskId=ea8b89fb-99be-470e-a788-6271c8172b6f

Related GitHub Issue

closes #78

How Has This Been Tested?

[x] Status checks pass
[x] Works on Goerli (@aahna-ashina)
[x] Works on Mainnet (@luisivan)

Are There Admin Tasks?

[x] @aahna-ashina SQL migration: 1.0.0.sql (passports-goerli)
[x] @aahna-ashina SQL migration: 1.0.0.sql (passports-mainnet)

Documentation

[x] https://github.com/nation3/mobile-passport/pull/79/commits/f670502808d1466f29cead9131c52a6fbbee83d7 Document steps for using /api/pushLastUpdate

vercel[bot] commented 2 years ago

@aahna-ashina is attempting to deploy a commit to the Nation3 Team on Vercel.

A member of the Team first needs to authorize it.

codecov-commenter commented 2 years ago

Codecov Report

Merging #79 (0f3b040) into main (b5aedc3) will decrease coverage by 0.60%. The diff coverage is 27.58%.

@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
- Coverage   81.00%   80.40%   -0.61%     
==========================================
  Files           5        5              
  Lines         179      199      +20     
  Branches       16       22       +6     
==========================================
+ Hits          145      160      +15     
- Misses         33       38       +5     
  Partials        1        1

Impacted Files	Coverage Δ
server/utils/Passes.ts	`80.91% <27.58%> (-3.77%)`	:arrow_down:
server/utils/SupabaseClient.ts	`100.00% <0.00%> (+100.00%)`	:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

aahna-ashina commented 2 years ago

@johnmark13 @xPi2 Pending review 🙏

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
mobile-passport	✅ Ready (Inspect)	Visit Preview	Sep 15, 2022 at 10:47AM (UTC)

luisivan commented 2 years ago

I keep getting this while trying to push the last update @aahna-ashina

aahna-ashina commented 2 years ago

I keep getting this while trying to push the last update @aahna-ashina

@luisivan Maybe because the Vercel preview for this PR has not been deployed?

aahna-ashina commented 2 years ago

@xPi2 Is it possible to automatically authorize Vercel deployments for my PRs in this repo?

luisivan commented 2 years ago

@aahna-ashina tried now, getting this error:

{"error":"Internal Server Error: FetchError: {very long string}\n is not a legal HTTP header value"}

Maybe \n isn't supposed to be there?

aahna-ashina commented 2 years ago

@luisivan Let me check. I'll try to reproduce on Goerli.

luisivan commented 2 years ago

It worked!!

aahna-ashina commented 2 years ago

@luisivan If we cannot reach 2 review approvals for this PR, do you have admin access to merge it?