nationalarchives / manage-your-collections

Front end code for the manage your collection application
2 stars 1 forks source link

MYC - no dates are displaying on Discovery #9

Closed CarolD closed 5 years ago

CarolD commented 5 years ago

From Caroline Catchpole: Unilever Archives have uploaded a collection and no dates are displaying on Discovery - this is the collection - http://discovery.nationalarchives.gov.uk/browse/r/h/413c7ef3-aaf1-45b0-9dce-9f54256d801c.

I’ve downloaded the collection from MYC – see attached. You’ll notice covering dates are filled out for the majority of the records but not all, which I think shows 2 issues(?)

  1. that the system validated the collection without dates for all records

  2. that the covering dates aren’t displaying on Discovery for the records that do have that field populated

CarolD commented 5 years ago

I couldn't replicate this at first as it was working perfectly with Caroline's file. I then realised, doh, it was from an export and once exported it's in the default spreadsheet format. And I need to check it via the mapper. So I've located the original spreadsheet from s3 and I'm using the same mappings that the user used. I've been able to find the issue, it was the issue: https://github.com/nationalarchives/manage-your-collections/issues/1 although I did a fix for this, I hadn't realised it was working for the default spreadsheets but not yet for mapped files. Although they use the same code, they are slightly different, so I need to look at that bit of code again. What I need to do is fix and test it. I'll also need to go back in the uploads to try to identify uploads that might be affected.

CarolD commented 5 years ago

had quick look on with archives have used mapping and might have affected collections ArchiveId | Name | RepositoryID | Issues | No. colls A14182834 | Friends of Hoar Oak Cottage | 3394 | N | 0 A13531340 | Royal Geographical Society | 402 | ? not yet checked | 153 A13530993 | University of Bristol: Theatre Collection | 811 | Y | 2 A13529955 | Unilever Archives and Records Archives | 1752 | Y | 4 A13530700 | Rotherham Archives and Local Studies | 198 | ? not yet checked | 540 A13530570 | Durham County Record Office | 32 | Y | 3 A13532822 | Newcastle University: Special Collections | 186 | ? not yet checked | 18

CarolD commented 5 years ago

I've put a fix for this on test and produced exports of spreadsheets for Caroline

CarolD commented 5 years ago

fix put live Monday 17/06