nationalarchives / tna-child-home

TNA Homepage child theme
http://www.nationalarchives.gov.uk/
0 stars 1 forks source link

Feature/hack alert link color #92

Closed grange85 closed 1 year ago

grange85 commented 3 years ago

When we made changes to the home page using the dark themed notification box it was noted that the link color wasn't changing so was displaying (once visited) as dark blue on black - I quickly hacked this css change to make all the a:link pseudo classes display as white.

It was also noted that any line breaks (or added html) was getting stripped so it wasn't possible to have the link on a new line - so ... there's another hack in there - I made the a tag a block-level element in the notification box.

Neither of these are likely to be the best way of resolving this - but, for an important update on a Friday night it was done (and pushed live).

When someone has a chance could they look at this - and fix if there's a better way of doing things.

Ideally:

I'm making this a draft PR - just so that it's there - as this dark notifcation box is important and likely to be used in inconvenient circumstance so it would be good it it worked as required.

grange85 commented 1 year ago

Closing stale PR