search

nationalarchives / tna-components

This repo will host all components and it's assets, built with JS & React
https://nationalarchives.gov.uk
MIT License
2 stars 1 forks source link

Add seperate runner for Discovery global search #99

Closed AshGDS closed 3 years ago

AshGDS commented 3 years ago

Hi @gtvj

Would you be able to check this PR and merge if all is OK?

I noticed on Discovery, "Search for records" should be the default search type on Global Search. This is how the legacy global search behaves. In order to get this functionality to work, I had to create a separate HTML id for React to hook onto, and that runner has a prop which tells react to show "Search for records" by default.

This PR also fixes React crashing on certain Discovery pages such as the homepage where Global Search doesn't exist. Unlike TNA/TNA-Base, etc., Discovery does not show global search across the application, but the runner was trying to render Global Search regardless of the HTML element's existence.

There's some slight CSS issues with the mobile search spacing on Discovery, but this is a Discovery CSS issue, not a component CSS issue so I will fix it in Discovery.

Thanks :+1:

AshGDS commented 3 years ago

Thanks @gtvj - I have made those changes :+1: