Instructions on wiki result in an error

nationalarchives / tna-frontend

TNA Frontend contains the code you need to start building user interfaces for National Archives platforms and services

https://nationalarchives.github.io/tna-frontend/

MIT License

2 stars 2 forks source link

Instructions on wiki result in an error #96

Closed timcowlishaw closed 6 months ago

timcowlishaw commented 6 months ago

Hey folks!

One quick issue i identified when trying to integrate the tna-frontend in nationalarchives/ds-caselaw-public - the instructions on the wiki result in an error because $largest-container-width is defined in px, then used in a calc statement with a variable defined in rem. I can't work out how to send a PR against a wiki page, but suggest the example here is changed to give a width in rem?

thanks!

Tim

ahosgood commented 6 months ago

Very good spot! Thank you, I have updated the wiki. 👍🏼