nationalarchives / tna

The National Archives WordPress theme
0 stars 0 forks source link

Non-HTML links (Page 48) #160

Open gtvj opened 5 years ago

gtvj commented 5 years ago

We need to include the file type in the link text for non-HTML links (like PDFs). Ideally this would be done in the source HTML but we'd need to identify a way to achieve this. Alternatives would be to do this with CSS (i.e. pseudo elements based on the href attr) or to use JavaScript to append the file type. Both have their drawbacks.

UPDATE: This is an editorial task, not a development task, and will need relevant pages to be updated via WordPress. See below for reason.

Estimate & timings

Timings
Estimate Editorial (Large)
Start date
End date
Actual date
Confidence
AshGDS commented 4 years ago

Hi @gtvj, does non-HTML links mean that they are linking to files, and not that they are being inserted to the page via Javascript?

gtvj commented 4 years ago

It does mean linking to files, yes. It’s things like PDFs and Excel files. Thanks @AshTNA

gtvj commented 4 years ago

While investigating this, @AshTNA has identified an issue that means we cannot address this with code. It seems some pages already have the file types appended, as is the case here: https://www.nationalarchives.gov.uk/information-management/manage-information/selection-and-transfer/selecting-records/osp-subject/. For this reason the changes will need to be made via content changes to WordPress.

gtvj commented 4 years ago

@MGDeVille / @grange85 - it seems this change will require content changes via WordPress editorial. Do you know how long it might take to identify and update all links to the PDF/Word docs etc.?

MGDeVille commented 4 years ago

Hi Gwyn.

I can do this – it’s very easy, just a bit laborious. One thing to add though is that the standard way that we write the link text for (e.g.) PDFs is how you currently see it, i.e. the PDF and file size info bit is NOT included in the link text.

So do we need to change all of the (many hundreds of) similar links?? Yikes.

Matthew

From: Gwyn Jones notifications@github.com Sent: 11 November 2019 14:47 To: nationalarchives/tna tna@noreply.github.com Cc: de Ville, Matthew Matthew.deVille@nationalarchives.gov.uk; Mention mention@noreply.github.com Subject: Re: [nationalarchives/tna] Non-HTML links (Page 48) (#160)

@MGDeVillehttps://github.com/MGDeVille / @grange85https://github.com/grange85 - it seems this change might require content changes via WordPress editorial. Do you know how long it might take to identify and update all links to the PDF/Word docs etc.?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/nationalarchives/tna/issues/160?email_source=notifications&email_token=ALEFJAM7VX255VMFWM2VN43QTFV4XA5CNFSM4IDYHNSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDXBMCA#issuecomment-552474120, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALEFJAOB27AYPXCJCMWZMETQTFV4XANCNFSM4IDYHNSA.


This email originates from the Internet and has been analysed for malware by Forcepoint Email Security Cloud.

If this email claims to come from a TNA colleague or department it should be treated with suspicion.

Use the PhishMe button to report any suspicious emails.


Please don't print this e-mail unless you really need to. ----------------------------------------------------------------------------------- National Archives Disclaimer This email and any files transmitted with it are intended solely for the use of the individual(s) to whom they are addressed. If you are not the intended recipient and have received this email in error, please notify the sender and delete the email. Opinions, conclusions and other information in this message and attachments that do not relate to the official business of The National Archives are neither given nor endorsed by it. ------------------------------------------------------------------------------------