education bundle fix padding

nationalarchives / tna

The National Archives WordPress theme

0 stars 0 forks source link

education bundle fix padding #193

Open AshGDS opened 5 years ago

AshGDS commented 5 years ago

http://test.nationalarchives.gov.uk/education/resources/medicine-on-the-western-front-part-two/

alternative link if the above doesnt work: http://test.nationalarchives.gov.uk/education/resources/significant-people-collection/

domjngo commented 5 years ago

Border top on the second and third h2 (not the first h2)
Remove border from feature-box, and give it a grey (#eee) background - I think it will look better against the hr
Can we also look at styling #bundle-container - it feels like it needs to be anchored
The menu list needs some thought - maybe keep it horizontal like previously as buttons?

sdwilkes commented 5 years ago

@AshTNA The thumbnails aren't displaying correctly on this page (might not be related to the rebrand work). Doesn't look like the masonry.js is loading correctly...

AshGDS commented 5 years ago

@sdwilkes The masonry code was making the resizing look buggy, so I removed it and fixed it using media queries. I've re-added it for now (i wasn't aware it would break the thumbnails!): https://github.com/nationalarchives/tna/blob/feature/rebrand/inc/footer-scripts.php#L87

netdesignr commented 5 years ago

@AshTNA on https://test.nationalarchives.gov.uk/education/resources/significant-people-collection

The thumbnails are still not visible
The content on Related resources is missing
More padding is needed on the grey boxes (Activity One, Activity Two etc..)

sdwilkes commented 4 years ago

@AshTNA Padding fix looks OK on this one.