nationalparkservice / EMLeditor

EMLeditor edits EML metadata to add required fields for DataStore and automates creating drafts and uploading data packages to DataStore
https://nationalparkservice.github.io/EMLeditor/
Other
5 stars 6 forks source link

set_creator_orcids adds problematic strings for authors with no orcids #126

Closed RobLBaker closed 7 months ago

RobLBaker commented 7 months ago

set_creator_orcids() is adding problematic strings if authors do not have orcids. In particular, the userId is set to https://orcid.org/NA.

In and of itself, this isn't all that bad (if a bit ugly) but problematially, DataStore interprets this as a valid orcid, adds an orcid icon to the relevant author, and creates a bad hyperlink. So on DataStore it appears that authors have orcids when they don't. And the link is bad.

Probably need input from the DataStore team on how they'd like this handled.