search

nationalparkservice / data

An unofficial repository of National Park Service data.
https://nationalparkservice.github.io/data
1.21k stars 86 forks source link

Fix broken link to IRMA portal in README.md #24

Closed rishirdua closed 4 years ago

npmap-bot commented 4 years ago

Hello!

I believe the link should be working now. Feel free to reach out and let me know if you run into any more issues.

On Mon, Jan 27, 2020 at 3:55 PM Rishi Dua notifications@github.com wrote:

You can view, comment on, or merge this pull request online at:

https://github.com/nationalparkservice/data/pull/24 Commit Summary

  • Fix broken link to IRMA portal in README.md

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nationalparkservice/data/pull/24?email_source=notifications&email_token=ABMCWPN5SUCGDJTUJ5KMHU3Q75Q5HA5CNFSM4KMJOMX2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IJCDECA, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABMCWPJTKTZZRRWJRTCKE3TQ75Q5HANCNFSM4KMJOMXQ .

rishirdua commented 4 years ago

The link still seems to be broken. I'm getting a 404

npmap-bot commented 4 years ago

Weird. Okay I'm going to have someone take a look at this. This is the screen I get when I click on it so I'm going to have some of my team mates test this too.

I think I'm going the "broken link" here. This is the link I see for portal in the readme and the image below is the site loading for me.: https://irma.nps.gov/Portal/?

[image: image.png]

On Mon, Jan 27, 2020 at 3:55 PM Rishi Dua notifications@github.com wrote:

You can view, comment on, or merge this pull request online at:

https://github.com/nationalparkservice/data/pull/24 Commit Summary

  • Fix broken link to IRMA portal in README.md

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nationalparkservice/data/pull/24?email_source=notifications&email_token=ABMCWPN5SUCGDJTUJ5KMHU3Q75Q5HA5CNFSM4KMJOMX2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IJCDECA, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABMCWPJTKTZZRRWJRTCKE3TQ75Q5HANCNFSM4KMJOMXQ .

npmap-bot commented 4 years ago

Hi Rishi,

The link appears to work for us on our end. Do you know if you can have someone on your end test it? https://irma.nps.gov/Portal/

It doesn't appear to be an internal link so this is very odd to me. :)

rishirdua commented 4 years ago

Currently the README mentions https://irma.nps.gov/App/Reference/Welcome (the one that doesn't work).

This commit changes it to https://irma.nps.gov/Portal/ (the one that works for both of us).

npmap-bot commented 4 years ago

Oh good! Okay let me see if I can fix this link.

From: Rishi Dua notifications@github.com Sent: Monday, February 3, 2020 10:19 PM To: nationalparkservice/data data@noreply.github.com Cc: NPMap Team, NPS npmap@nps.gov; Comment comment@noreply.github.com Subject: [EXTERNAL] Re: [nationalparkservice/data] Fix broken link to IRMA portal in README.md (#24)

Currently the README mentions https://irma.nps.gov/App/Reference/Welcome (the one that doesn't work).

This commit changes it to https://irma.nps.gov/Portal/ (the one that works for both of us).

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/nationalparkservice/data/pull/24?email_source=notifications&email_token=ABMCWPME6VMOA5R5E4LAZFTRBCJ7TA5CNFSM4KMJOMX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKVTTVY#issuecomment-581646807, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABMCWPNSP6LGUPWXDQKOZTLRBCJ7TANCNFSM4KMJOMXQ.

rishirdua commented 4 years ago

Hi there, would you be able to merge this commit so that the link gets fixed? Thanks!