search

nationalparkservice / places-api

An API, written in Node as Express middleware, built to work with the OSM API database schema. Used internally by Places.
The Unlicense
0 stars 0 forks source link

Add FDW and missing views #16

Closed regan-sarwas closed 9 years ago

regan-sarwas commented 9 years ago

These views and foreign data wrappers are in the places databases, but not in the build scripts, and are required to support changeset closing.

jimmyrocks commented 9 years ago

Before I approve these, I have a question. It looks like the code in this commit: https://github.com/regan-sarwas/places-api/commit/6f95d9a4b828ce39539a5e67cc8793795b701e80 Will need to be run on the dev/test/prod databases. Please confirm that this is what you want, and I'll will test and implement it.

regan-sarwas commented 9 years ago

No, your databases are fine as is. The schema in the test database was the source for this change. This PR attempts to update the build scripts to match what I was able to reverse engineer from the test database. Since I do not have a pg_dump of the database, I needed to these build scripts to build the database from scratch. I think I got it right (everything seems to work). I'm not sure if you are trying to keep these build scripts up to date with changes you are making directly in the database. Having the scripts is helpful for someone like me who is implementing a test system from scratch.

jimmyrocks commented 9 years ago

I do plan to keep the scripts in the database up to date with what is in github. Right now they are a little off from each other. I do have a ton of code to add to github for the new tagging style. I should make it a priority to get it in there.

On Thu, Oct 1, 2015 at 3:38 PM, Regan Sarwas notifications@github.com wrote:

No, your databases are fine as is. The schema in the test database was the source for this change. This PR attempts to update the build scripts to match what I was able to reverse engineer from the test database. Since I do not have a pg_dump of the database, I needed to these build scripts to build the database from scratch. I think I got it right (everything seems to work). I'm not sure if you are trying to keep these build scripts up to date with changes you are making directly in the database. Having the scripts is helpful for someone like me who is implementing a test system from scratch.

— Reply to this email directly or view it on GitHub https://github.com/nationalparkservice/places-api/pull/16#issuecomment-144825547 .