search

nationalparkservice / places-api

An API, written in Node as Express middleware, built to work with the OSM API database schema. Used internally by Places.
The Unlicense
0 stars 0 forks source link

Async upload changeset #20

Closed regan-sarwas closed 8 years ago

regan-sarwas commented 8 years ago

Jim, this works well on my test server. the data/source query will return a 404 while the changes is processing, and then good results when it is done, so I can poll for results to finish processing on the client end.

A draw back to large uploads (with the async call or the regular call) is that while queries against snapshot are responsive, it appears the api database (at least on my server) becomes unresponsive to new requests while the upsert changeset transaction is processing.

I don’t anticipate many large uploads (we have two, and I can schedule them for off hours), and I think other parks/regions plan to send you the osm upload file for large uploads, so this hopefully will not be a problem.

Nevertheless, I can program a time of day restriction on large uploads.

thoughts?

jimmyrocks commented 8 years ago

This looks really cool. I'll have to look into the issue with the api processing large requests. I'll be testing it tomorrow morning.

On Wed, Sep 30, 2015 at 3:40 PM, Regan Sarwas notifications@github.com wrote:

Jim, this works well on my test server. the data/source query will return a 404 while the changes is processing, and then good results when it is done, so I can poll for results to finish processing on the client end.

A draw back to large uploads (with the async call or the regular call) is that while queries against snapshot are responsive, it appears the api database (at least on my server) becomes unresponsive to new requests while the upsert changeset transaction is processing.

I don’t anticipate many large uploads (we have two, and I can schedule them for off hours), and I think other parks/regions plan to send you the osm upload file for large uploads, so this hopefully will not be a problem.

Nevertheless, I can program a time of day restriction on large uploads.

thoughts?

You can view, comment on, or merge this pull request online at:

https://github.com/nationalparkservice/places-api/pull/20 Commit Summary

  • async changeset upload
  • Merge branch 'nationalparkservice/master' into async-upload-changeset

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/nationalparkservice/places-api/pull/20.

jimmyrocks commented 8 years ago

This looks awesome, thanks!