search

nationalparkservice / places-api

An API, written in Node as Express middleware, built to work with the OSM API database schema. Used internally by Places.
The Unlicense
0 stars 0 forks source link

api/data/source/:id reports 404 when changeset exists #25

Open regan-sarwas opened 8 years ago

regan-sarwas commented 8 years ago

A 404 error is returned when the changeset does not exist (appropriately), and when the changeset exists, but is not ready since it has not been closed (503 Service Unavailable seems like a better fit). A different return code is nice since a client (arc2places) may want to respond differently in these two cases.

jimmyrocks commented 8 years ago

That does make sense. Is it returning 404 now?

On Fri, Oct 2, 2015 at 1:23 PM, Regan Sarwas notifications@github.com wrote:

A 404 error is returned when the changeset does not exist (appropriately), and when the changeset exists, but is not ready since it has not been closed (503 Service Unavailable seems like a better fit). A different return code is nice since a client (arc2places) may want to respond differently in these two cases.

— Reply to this email directly or view it on GitHub https://github.com/nationalparkservice/places-api/issues/25.

regan-sarwas commented 8 years ago

Yes, unless the changeset is closed, and then I get my data as expected. I would assign this to me if I could.