search

nationalparkservice / places-data

Data from the Places system.
http://www.nps.gov/npmap/tools/places/
13 stars 5 forks source link

Removing "Hospital Building", "Hotel Building", "Four-Wheel Drive Road" presets #134

Closed chadlawlis closed 8 years ago

chadlawlis commented 8 years ago

@asouthwould we would like to propose the removal of these two point presets. "Hotel Building" is effectively a duplicate of "Lodging" and "Hospital Building" is a duplicate of "Hospital". Are there any specific use cases you had in mind that we should know about, or other concerns associated with removing these?

Copying @jimmyrocks for his visibility.

chadlawlis commented 8 years ago

Adding "Four-Wheel Drive Road" to this list of what we'd like to remove.

@asouthwould, I remember that both the road and trail GIS standards include a four-wheel drive vehicle classification, as follows (from our work during the mapathon):

In Editor, we have both "Four-Wheel Drive Road" (which RDCLASS=4WD maps to) and "Four-Wheel Drive Trail" (which TRLUSES=Four-Wheel Drive Vehicle > 50" in Tread Width maps to). We would like to remove "Four-Wheel Drive Road" from the Editor, so that "Four-Wheel Drive Trail" is the only preset that comes up when "four wheel..." is searched, but we would also like to remove the tag altogether if it's possible to map both GIS classifications to "Four-Wheel Drive Trail".

For now, we are removing the road from editor and will await your feedback as to hanging on to the preset in general or removing it.

Thanks!

asouthwould commented 8 years ago

I support removing Hotel Building and using Lodging. I support removing Hospital Building and using Hospital. I agree that these two changes will simplify choices.

I do NOT support the merging of Four-Wheel Drive Road and Four-Wheel Drive Trail.

I know this may seem confusing, but 4WD access is permissible within both the Roads and Trails spatial data standards because this is a valid classification for either of these entities. To physically observe one of these 4WD paths, you may not be able to discern between the two. It is more of a political decision by the park to call something a "Road" or a "Trail" and those two terms should not be interchanged. With that, if the park directs me to put a feature into their Roads dataset and classify it as a 4WD road, I feel very uncomfortable with that being reclassified and publicly displayed as a trail. Or vice versa. Thanks!

chadlawlis commented 8 years ago

Sounds good, thanks Angie. We are going to remove the "Four-Wheel Drive Road" preset from Places Editor for now, to avoid confusion for people tracing from satellite imagery, but we will continue to support it for GIS imports. If it turns out parks would like the option for both we can always add it back in.

asouthwould commented 8 years ago

That sounds good to us... as long as 4WD "Trails" coming in from GIS are rendered more like the other trail features and 4WD "Roads" are rendered more like the other road features. I think that's going to be the most important factor from the park perspectives; they will want distinction between the look of these two feature types on a map. Thanks!

nateirwin commented 8 years ago

Ugh, now I'm kind of having second thoughts about this. What are you thinking, @cwlawlis802?

chadlawlis commented 8 years ago

@nateirwin well, the underlying tag for the road classification will still be supported, so it should continue to be accessible cartographically. Users just won't be able to add this as a preset directly through Editor.

What are you thinking?

nateirwin commented 8 years ago

Guess I'm just thinking that maybe we should continue to support both "Four-Wheel Drive Road" and "Four-Wheel Drive Trail". I was focused on making the presets in Places Editor more intuitive, but I think @asouthwould brings up a really good point about parks wanting to add this use case to both roads and trails.

chadlawlis commented 8 years ago

Okay, we can add it back in... We won't include it in the default road preset list, but it will be searchable.

jimmyrocks commented 8 years ago

We can also leave it in there so it's not even searchable, but will still show up if someone manually enters the tags.

On Thu, Sep 3, 2015 at 12:01 PM, Chad Lawlis notifications@github.com wrote:

Okay, we can add it back in... We won't include it in the default road preset list, but it will be searchable.

— Reply to this email directly or view it on GitHub https://github.com/nationalparkservice/places-data/issues/134#issuecomment-137529500 .

chadlawlis commented 8 years ago

Just to tie up any loose ends here, we are continuing to support "Four-Wheel Drive Road" in Editor as search-only.

"Hospital Building" and "Hotel Building" have been removed.

jimmyrocks commented 8 years ago

On Thu, Sep 10, 2015 at 1:48 PM, Chad Lawlis notifications@github.com wrote:

Just to tie up any loose ends here, we are continuing to support "Four-Wheel Drive Road" in Editor as search-only.

"Hospital Building" and "Hotel Building" have been removed.

— Reply to this email directly or view it on GitHub https://github.com/nationalparkservice/places-data/issues/134#issuecomment-139323111 .

chadlawlis commented 8 years ago

inEditor is currently set to TRUE, is that not the field dictating searchability in Editor?

jimmyrocks commented 8 years ago

That is the field dictating searchability in Editor.

On Thu, Sep 10, 2015 at 2:01 PM, Chad Lawlis notifications@github.com wrote:

inEditor is currently set to TRUE, is that not the field dictating searchability in Editor?

— Reply to this email directly or view it on GitHub https://github.com/nationalparkservice/places-data/issues/134#issuecomment-139328879 .

chadlawlis commented 8 years ago

Set to FALSE now, we're good!