search

nationalparkservice / places-data

Data from the Places system.
http://www.nps.gov/npmap/tools/places/
13 stars 5 forks source link

Horse camps do not render at all #264

Open tpcolson opened 8 years ago

tpcolson commented 8 years ago

Horse camps do not render at all, even though they are reservable campgrounds in rec.gov. E.g tags {"fee": "yes", "name": "Anthony Creek Horse Camp", "horse": "yes", "sport": "equestrian", "source": "NPS", "leisure": "horse_riding", "tourism": "camp_site", "nps:fcat": "Campground", "nps:unit_code": "grsm", "official_name": "Anthony Creek Horse Camp"} , which is a campground, get pushed into the "Horseback Riding" type, while {"name": "Cades Cove Campground", "source": "nps:points_of_interest", "tourism": "camp_site", "nps:fcat": "Campground", "nps:type": "Developed", "nps:places_id": "acffaa35-3f08-4f27-82bf-54d8bccf0235", "nps:unit_code": "grsm"} renders correctly in PT 3.0 as a campground. http://www.nps.gov/grsm/planyourvisit/upload/GSMNP-Map_JUNE14-complete4-2.pdf shows the correct symbology for the various type of campground (horse/people). Features with the tag "tourism": "camp_site" should be in the "Campground" Type.

jimmyrocks commented 8 years ago

The issue here is that the first point is tagged as both {"tourism": "camp_site"} and a {"leisure:" "horse_riding"} Both of these map up to different presets, and both of these presets currently have the same priority, so you're seeing a collision where the tags to presets function doesn't have enough information to decide the correct tag, so it is currently just choosing whichever tag appears first in Alphabetical order (in this case leisure over tourism).

This can be solved in three ways:

  1. Assign a higher match score to campgrounds, so anything with a campground tag will ignore any other presets with an equal amount of matching tags
  2. Tag these two entities separately so they can show up on the map properly.
  3. Introduce a new tag that includes leisure=horse_riding, and call it "Horse Camp with Horseback Riding"
jimmyrocks commented 8 years ago

This looks to be an issue with the "*" matching in the SQL code, if that's the case, it has something to do with this line of code: https://github.com/nationalparkservice/places-api/blob/master/scripts/sql_scripts/pgs/func_presets.sql#L93

or it could be here: https://github.com/nationalparkservice/places-api/blob/master/scripts/sql_scripts/pgs/func_presets.sql#L102-L106

nateirwin commented 8 years ago

How's this one coming along, @jimmyrocks? Seems like it may be fixed? Or you have some ideas on how we can improve this behavior?

jimmyrocks commented 8 years ago

The issue was with conflicting tags. We cleaned up many of the conflicting use type tags and updated them in the editor / rendered tiles.

This specific issue shows a tag conflict between "Primitive Camping" and "Horse Camping". Since it matches the same amount of tags for both of these presets. These presets are set to be assigned in an order if more than one preset is matched, and "Primitive Camping" is ranked higher than "Horse Camping" in our system, and we think this is the best order to go with.

We could add "Primitive Horse Camping" as a preset if it is deemed to be important enough to be separated.

Otherwise, we plan to expose the use type tags in cartodb in the GIS standard so that while the preset for this object will be "Primitive Camping", GIS users can determine that horses are allowed a this campsite.

We currently do not support the GIS standard in our CartoDB outputs, and are working toward parsing our data to match. Once that issue is resolved, we can go back and close this issue.

On Mon, Dec 21, 2015 at 5:50 PM, Nate Irwin notifications@github.com wrote:

How's this one coming along, @jimmyrocks https://github.com/jimmyrocks? Seems like it may be fixed? Or you have some ideas on how we can improve this behavior?

— Reply to this email directly or view it on GitHub https://github.com/nationalparkservice/places-data/issues/264#issuecomment-166445588 .

tpcolson commented 8 years ago

I think there are two issues here: Front-country and back-country. A front-country horse campground, one you can drive your horsie trailer to (and one that you would not otherwise want to camp at), is generally symbolized with the HFC "horse inside a building" icon, while a back-country campsite (primitive) which coincidentally allows horses, would get the same icon as any other BC site (A tent, or a shelter).