nationalparkservice / places-data

Data from the Places system.
http://www.nps.gov/npmap/tools/places/
13 stars 5 forks source link

Implement NPS shields in PT3 using ref tag #352

Open mtaylorlong opened 8 years ago

mtaylorlong commented 8 years ago

OSM highway shields are still showing up inside of park boundaries, and it looks strange where parks haven't yet drawn in the roads. We did this because the OSM data has the necessary attributes to detect highways and most NPS data would need to be modified to sort this out.

For the second beta update of PT3, I'm removing these shields inside park boundaries. I'm going to try to implement our own highway shields for Places data and write up instructions for how to tag roads to take advantage of these shields.

mtaylorlong commented 8 years ago

In order to implement route numbers using places data, we would need to change some things in Places, so this may not be feasible in our first release of Park Tiles 3. @jimmyrocks explained that OSM handles route numbers with relations, but this may be difficult to copy since we handle our vector tiles differently. It sounds like the simple approach would be to treat all highways the same (using the Highway preset), and use the ref key to collect route numbers. Then we would render out the ref number as an attribute in our Mapbox tiles called route_number. However, Jim says there may be some shortfalls with this approach, so we need to think about it more as a group.

cc @jakecoolidge, @nateirwin, @cwlawlis802.

mtaylorlong commented 8 years ago

I still think the ref approach is the most feasible near-term option. I don't think @jimmyrocks has added this in the places lines vector tiles yet, so I'm putting this one off into the next milestone.

@jimmyrocks: When you're ready, will you take anything in the ref tag and add it to our tiles as route-number? Once I have an example there, I can get some simple NPS-ish looking shields up and running.