nationalparkservice / places-tracing-guide

A tracing guide for the National Park Service's Places system
https://www.nps.gov/maps/tools/places/tracing-guide/
3 stars 4 forks source link

Tracing Guide Feedback #3

Closed chadlawlis closed 8 years ago

chadlawlis commented 9 years ago

Now that the first iteration of the guide is complete (with the exception of a few final GIFs), please submit any feedback here.

makella commented 9 years ago

I think it would be good to talk about the 'Park Tiles Rendering' piece. We need to think about Park Tiles as almost separate because the POIs are not burnt into the basemap. So if someone expects that they are going to see these icons when they access Park Tiles in Builder, they aren't (at least for now).

Maybe another way to say it is Cartographic Rendering or Map Rendering? I'm not exactly sure what is best and think it would be a good discussion for us to have.

Also, the POIs that are on the guide are not all represented on the Park Tiles POI overlay... should they be? If so, let us know.

jakecoolidge commented 9 years ago

Chad and I talked about this, but I'll capture it here:

For the parking section: one idea is to remove paragraphs 2 and 3 from the first section, as these instructions echo instructions in the subsequent sections, and move the point, line, and area images to the subsequent Parking Amenity and Parking Aisle sections.

I think the separation of information in the Trails section is more intuitive to me. You begin with broad/entry-level info, and then elaborate later on--especially helpful when the mapper has more robust information to add to each trail.

makella commented 9 years ago

Small thing: the visitor center icon that you have in the doc is not the same one that is rendered on the Park Tiles POI overlay... Jake can get you the one that we use for consistency.

I'll actually read through more of the guide these are just some small observations!

chadlawlis commented 9 years ago

@makella in reference to Park Tiles Rendering:

Good question, thanks for pointing that out. Changing to Map Rendering or Places Rendering makes sense here - the intention was to show the user how the icon will appear on the map in Places editor, not Park Tiles. I'm always tempted to mention Park Tiles when discussing any form of our map rendering, so good catch.

I'm not sure about needing to represent these POIs in the Park Tiles overlay, although they are some of the most common added to Places so it might make sense? Is there a list of the POIs available in the overlay I could take a look at?

chadlawlis commented 9 years ago

@makella in reference to the VC icon:

If you or @jakecoolidge could point me to the most recent icon that would be great. I've been pulling the icons from here.

chadlawlis commented 9 years ago

@jakecoolidge in reference to the Parking section:

This makes sense to me, although I have been listing the tools (Area, Point, and Line) in the introductory sections for each data type so I would like to try to keep that consistent to the extent possible. I definitely agree with your point about overlap/repetition of information from the introductory section to the Parking (amenity) and Parking Aisle sub-sections, so I will look to cut that down/remove it.

makella commented 9 years ago

Hey Chad, that is an excellent way to determine what should be drawn in the Park Tiles POI overlay. If there are particular features that are being added most to Places, yes! let's get those on the map! That means they are important and the users are telling us that by adding them. I really like that as a measure of what we should display.

We currently symbolize:

jakecoolidge commented 9 years ago

@cwlawlis802: Our symbol repos need work. I was going to put the symbols that we use as overlays in Park Tiles in NPMaki, but I got tripped up--mainly because this is still a fork of Maki, so my pull request isn't set up right...(insert boring details). Instead, I'm hosting stuff here until we can get this sorted out:

https://github.com/nationalparkservice/symbol-library/tree/master/svg-set-comprehensive

If you have any questions on this repo, let me know.

nateirwin commented 9 years ago

The description for "Unclassified Road states, "It is of lower importance than a tertiary road..." But we aren't collecting tertiary roads. Should "tertiary road" be changed to "secondary road"?

nateirwin commented 9 years ago

I know you took most of the first few paragraphs from existing text, but I recently had a conversation with someone in the NPS who recommended that we stop using the phrase "internal crowd-sourcing" altogether. He said we should say something more like "we've opened data collection so more people can contribute." Apparently "crowd-sourcing" worries some in leadership, and they end up focusing on that and not on the positives.

Just a thought.

nateirwin commented 9 years ago

Rather than just saying "Start mapping now!" at the top, perhaps we should say, "If you are on the NPS network, start mapping now!" (or something like that).

nateirwin commented 9 years ago

It looks like some of NPS Bootstrap's fonts are getting overridden by styles set in style.css. In particular, line 13:

body,
h1,
h2,
h3,
h4,
h5,
h6 {
  font-family: "Lato","Helvetica Neue",Helvetica,Arial,sans-serif;
  font-weight: 700;
}

does not need to be there.

chadlawlis commented 9 years ago

@makella in reference to POI Park Tiles overlay:

Below are the top 20 POIs (by tag count) in Places, which might help inform any additions to the overlay list. I think it would be worthwhile for the POI overlay to mirror the primary POIs listed in the guide (or vice versa), so the most common information users are adding to the map are available for use as well.

  1. Campground; 2025; {"tourism":"camp_site"}
  2. Parking; 1394; {"amenity":"parking"}
  3. Picnic Area; 1167; {"tourism":"picnic_site"}
  4. Restroom; 725; {"amenity":"toilets"}
  5. Trailhead; 460; {"highway":"trailhead"}
  6. Visitor Center; 418; {"tourism":"information, "information":"office"}
  7. Ranger Station; 374; {"amenity":"ranger_station"}
  8. Boat Launch; 363; {"leisure":"slipway"}
  9. Office; 305; {"building":"office"}
  10. Office; 305; {"office":"*"}
  11. Canoe Access; 155; {"access":"canoe"}
  12. Food Service; 125; {"amenity":"food_court"}
  13. Wheelchair Accessible; 108; {"wheelchair":"yes"}
  14. Lodging; 98; {"tourism":"hotel"}
  15. Telephone; 84; {"amenity":"telephone"}
  16. Entrance Station; 82; {"barrier":"entrance"}
  17. Drinking Water; 79; {"amenity":"drinking_water"}
  18. Waterfall; 78; {"waterway":"waterfall"}
  19. Swimming Area; 72; {"sport":"swimming"}
  20. Information; 65; {"tourism":"information"}

Let me know if there are any you are thinking of including in the overlay that are not in the guide and I can add those in as well.

chadlawlis commented 9 years ago

@jakecoolidge in reference to symbols:

Is there a VC icon in there? Can't seem to find it.

jakecoolidge commented 9 years ago

@cwlawlis802 sorry about that. It's there now.

It's meant to be comprehensive in the near future, but I haven't created all the svgs from the source Illustrator files yet.

chadlawlis commented 9 years ago

@nateirwin re: unclassified road description: :heavy_check_mark: (changed to secondary road)

re: crowd-sourcing what do you think about:

Places is an internal data collection system for the National Park Service's "core" geospatial data.

compared to the original

Places is an internal crowd-sourcing system for the National Park Service's "core" geospatial data.

re: start mapping now what do you think about this:

start_mapping_now

and finally re: fonts :heavy_check_mark: good catch!

chadlawlis commented 9 years ago

@jakecoolidge great, got it - thanks!

nateirwin commented 9 years ago

Looks good to me!

chadlawlis commented 9 years ago

@jakecoolidge (re: parking) take a look at the update to the parking description and let me know what you think. Live on the site here.

chadlawlis commented 9 years ago

@makella all set with the updated VC icon pulling from the symbol library repo :heavy_check_mark:

jakecoolidge commented 9 years ago

@cwlawlis802: looks good. I think the parking section is done once the images are up.

chadlawlis commented 9 years ago

@jakecoolidge great, thanks for the feedback

nateirwin commented 9 years ago

I don't see parking aisle in the tracing guide. It should be there, right?

chadlawlis commented 9 years ago

@nateirwin it's in there: http://nationalparkservice.github.io/places-tracing-guide/#parking_aisle

nateirwin commented 9 years ago

Ah, great. Guess I figured it would be under the roads section. That leads to another thought: Can we document our recommendation(s) for road, trail, and parking lot topologies? For example, do we recommend that trails connect to roads? And do we recommend bringing a primary, secondary, or service road and connecting it to the entrance of a parking lot and then using either service road or parking aisle in the parking lot itself?

chadlawlis commented 9 years ago

@nateirwin sure, can do. This is probably something we should think through before I write it up. So, let's discuss this in the issue I created. I'll do a little research to see how this is handled in OSM and make initial recommendations, which I will seek feedback on for a general consensus.

On first thought I am assuming yes to trails connecting to roads and yes to using a service road to connect to the entrance of a parking lot and then parking aisles inside of the parking lot.

tpcolson commented 9 years ago

The IRMA Data Store records (https://irma.nps.gov/App/Reference/Profile/2222347) contain extracts in 4 formats (geojson, shape, kml, csv)...the links to download just geojson in the 3rd paragraph should point to the metadata records, each of which have a link for each of the 4 download types. As this is the landing page for most NPS access to the system, want to make sure not to alienate folks whom aren't familiar with geojson and how to use it. Or....include reference that other formats are supported and link, else where on this page, to those downloads.....actually, this one link will give you everything in all formats...https://irma.nps.gov/App/Reference/GroupedProducts?parentReferenceCode=2222347

nateirwin commented 9 years ago

Added links to the IRMA records to the public Places landing page: http://www.nps.gov/npmap/tools/places/. Does that take care of what you are looking for, @tpcolson?

tpcolson commented 9 years ago

perfect

tpcolson commented 9 years ago

This is really nit-picky....but the links to the OSM Wiki pages, e.g for "maxspeed=" goes to directly to http://wiki.openstreetmap.org/wiki/Key:maxspeed....these should either open in a new window...or...should have the standard "Leaving the NPS web page" notice .....

jimmyrocks commented 9 years ago

Tom, we actually looking at changing all of those OSM Wiki links to point to the tracing guide. It can be a little confusing to push people out to OpenStreetMap while they're using our editor.

On Fri, Jun 19, 2015 at 1:37 PM, Thomas Colson notifications@github.com wrote:

This is really nit-picky....but the links to the OSM Wiki pages, e.g for "maxspeed=" goes to directly to http://wiki.openstreetmap.org/wiki/Key:maxspeed....these should either open in a new window...or...should have the standard "Leaving the NPS web page" notice .....

— Reply to this email directly or view it on GitHub https://github.com/nationalparkservice/places-tracing-guide/issues/3#issuecomment-113617110 .

nateirwin commented 8 years ago

Closing for now. I think we've addressed everything covered in this issue either directly in the tracing guide or in another open issue.