search

natir / yacrd

Yet Another Chimeric Read Detector
MIT License
72 stars 8 forks source link

Mismatched types #42

Closed dpryan79 closed 3 years ago

dpryan79 commented 3 years ago

I imagine this is a change in clap, but on Bioconda I'm running into the following errors during compilation:

2021-03-31T20:34:40.9529590Z 20:34:40 BIOCONDA INFO (ERR) error[E0308]: mismatched types
2021-03-31T20:34:40.9533120Z 20:34:40 BIOCONDA INFO (ERR)   --> src/cli.rs:45:17
2021-03-31T20:34:40.9535020Z 20:34:40 BIOCONDA INFO (ERR)    |
2021-03-31T20:34:40.9536860Z 20:34:40 BIOCONDA INFO (ERR) 45 |         short = "i",
2021-03-31T20:34:40.9538000Z 20:34:40 BIOCONDA INFO (ERR)    |                 ^^^ expected `char`, found `&str`
2021-03-31T20:34:40.9538590Z 20:34:40 BIOCONDA INFO (ERR)

Perhaps you've already fixed this in the main branch (I don't know rust, but I assume this should be 'i' rather than "i") and if so it'd be great if you could tag a new release soon.

natir commented 3 years ago

Yes It's solve on master.

yacrd is using a beta version of clap so that's probably why this error appeared.

I may consider releasing a new version if necessary.

dpryan79 commented 3 years ago

Cool, I've patched this over on bioconda, so no rush from our end :)