search

native-html / plugins

Plugins for react-native-render-html
MIT License
55 stars 18 forks source link

Added main table border styles #10

Closed nadav2051 closed 4 years ago

jsamr commented 4 years ago

@nadav2051 Can you provide at least visual tests to show the result?

nadav2051 commented 4 years ago

Sure, can you instruct me on how to create tests?

On Tue, Mar 17, 2020, 19:10 Jules Sam. Randolph notifications@github.com wrote:

@nadav2051 https://github.com/nadav2051 Can you provide at least visual tests to show the result?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jsamr/react-native-render-html-table-bridge/pull/10#issuecomment-600190716, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABR6QDEFAD4L3KBTYVXZUJ3RH6VJHANCNFSM4LNNJWSA .

jsamr commented 4 years ago

Oh ; by visual test I just meant an example code and a screenshot of the result!

jsamr commented 4 years ago

@nadav2051 Thanks for your participation. I ended up implementing this differently as I decided to reorganize the TableStyleSpecs for release 2.0!

nadav2051 commented 4 years ago

@nadav2051 Thanks for your participation. I ended up implementing this differently as I decided to reorganize the TableStyleSpecs for release 2.0!

Awesome, thank you! Apologies for forgetting to submit the screenshots / example code - it totally slipped my mind

jsamr commented 4 years ago

@nadav2051 no worries!

jsamr commented 4 years ago

I also added a sketch of different style specs to easily identify which does what, see https://github.com/native-html/table-plugin/blob/master/docs/table-plugin.tablestylespecs.md