nativeformat / NFPlayerJS

A JavaScript/TypeScript audio engine for the Web and Server capable of multitrack time stretching, pitch shifting, declarative effects, faster than realtime processing, and more!
https://nativeformat.github.io/NFPlayerJS
Apache License 2.0
130 stars 9 forks source link

Player does not respect Grapher "ports" #2

Open kirbysayshi opened 5 years ago

kirbysayshi commented 5 years ago

"Ports" allow for control signals that are required by a node to process its audio: https://github.com/spotify/NFGrapher/blob/36cb827667f580c68c5a28fdc2000afcde2bfcf1/smart-player-contract.json#L540-L562

Required for anything like sidechain compression. Right now the Player just assumes all inputs are audio for inclusion in the final output. Luckily no nodes right now require this, but a compressor is very useful.