search

nativescript-community / algolia

NativeScript plugin for Algolia search.
Other
2 stars 2 forks source link

Bugfix/issue 2 #3

Closed shiv19 closed 3 years ago

shiv19 commented 3 years ago

Summary

This PR fixes the export for CompletionHandler in algolia-index

Previous behaviour

Building with webpack gives this warning

WARNING in ./node_modules/@nativescript-community/algolia/algolia.android.js 12:38-55
export 'CompletionHandler' (imported as 'CompletionHandler') was not found in './algolia-index' (possible exports: AlgoliaIndex)
 @ ./app/pages/findRecipes/findRecipes-page.js 5:0-58 142:26-33
 @ ./app/ sync .(xml|js|s?css)$ ./pages/findRecipes/findRecipes-page.js
 @ ./app/__@nativescript_webpack_virtual_entry_javascript__ 3:16-89

New behavior

The warning won't show up anymore.

keerl commented 3 years ago

Thanks for fixing that! Just merged and published to v1.2.6.