Closed CatchABus closed 4 years ago
@DimitrisRK can you try 0.1.19? should work now. Thanks for reporting
Thanks a lot for the quick response. It seems to be working for android now, though installed plugin module contains source files along with bundle file (is this expected behaviour?). Also, a test for iOS apps is needed as files seem quite different too in addition to NS6 version plugin. Screenshots among versions: iOS 0.1.16
iOS 0.1.19
Yes that a major layout change i brought. Instead of "publishing" compiled native libs, i publish sources directly which will be build directly during your app build. I prefer that way because it makes debugging users build logs easier.
@farfromrefug Sorry, I'm not familiar with iOS and I noticed that new version is missing a file called "GestureHandler". I like this new approach.
@DimitrisRK i like it too. However it requires to check and test your sources before publishing because you do not "compile" them. I will fix that though, i know how to do it
@farfromrefug One little thing I confirmed. In my case, this line is causing error during plugin manual build: https://github.com/nativescript-community/gesturehandler/blob/master/src-native/android/gesturehandler/build.gradle#L61 Removing it completely solved issues.
yes that line should not be there anymore. But you should not go there anymore, right?
You are right. Just wanted to point it out, but forgot build is done in a different way now. :)
Yes i will fix it! thanks, just did that the canvas. Now native is built to test on publish
Actually still failing on iOS :( working on it but got some N issues now...)
Ah I see. I wish I had some mac equipment to help or report but my hands are tied here. I reopen this issue.
@farfromrefug Is this issue still open?
Actually no. Thanks @DimitrisRK :)
Which platform(s) does your issue occur on?
Please, provide the following version numbers that your issue occurs with:
Please, tell us how to recreate the issue in as much detail as possible.
Installing plugin on a project and attempting to run app causes this error: