search

nativescript-community / https

Secure HTTP client with SSL pinning for Nativescript - iOS/Android
https://nativescript-community.github.io/https/
Other
51 stars 42 forks source link

Request Timeout #48

Closed bobbyngwu closed 4 years ago

bobbyngwu commented 4 years ago

Thanks for the plugin. It may be helpful to allow a timeout property in the HttpRequestOptions interface to be used to override the okhttp3 Request default 10 seconds timeout

EddyVerbruggen commented 4 years ago

That sounds pretty useful indeed! And perhaps something similar is possible on iOS as well (via AFNetworking. Are you able to take a stab at it?

bobbyngwu commented 4 years ago

Sure, will have a look

bobbyngwu commented 4 years ago

Hi Eddy, I have a PR for this, do you mind granting me limited permission to create a branch?

EddyVerbruggen commented 4 years ago

Hi, there’s no need for permissions. Just fork this repo and submit a pr 👍

bobbyngwu commented 4 years ago

Thanks Eddy, confused this with GitLab in mind :)