search

nativescript-community / https

Secure HTTP client with SSL pinning for Nativescript - iOS/Android
https://nativescript-community.github.io/https/
Other
51 stars 42 forks source link

allow wildcard domains #52

Closed kanayo closed 4 years ago

kanayo commented 4 years ago

Add commonName option to handle cases where CN != hostName, eg host= sales.company.com, CN=*.company.com

See issue:

https://github.com/EddyVerbruggen/nativescript-https/issues/14

EddyVerbruggen commented 4 years ago

That's wonderful, thank you!

EddyVerbruggen commented 4 years ago

@kanayo btw, is this also possible for iOS, or don't we need it there?

kanayo commented 4 years ago

It looks like this case is covered by AFNetwork on iOS:

https://github.com/AFNetworking/AFNetworking/pull/1865

Which makes me think, it would be better to just implement the matching algorithm described there, then we wouldn't need the Android-only "commonName" option.

EddyVerbruggen commented 4 years ago

@kanayo Yes that makes sense!