search

nativescript-community / https

Secure HTTP client with SSL pinning for Nativescript - iOS/Android
https://nativescript-community.github.io/https/
Other
51 stars 42 forks source link

feat(angular): handle params #89

Closed lekhmanrus closed 9 months ago

lekhmanrus commented 9 months ago

Handle Angular params to form the correct URL.

farfromrefug commented 9 months ago

@lekhmanrus thanks it is now released

lekhmanrus commented 9 months ago

@farfromrefug thank you!

lekhmanrus commented 9 months ago

Hey @@farfromrefug, For some reason, v4.1.3 doesn't contain an angular folder. Maybe, has something changed in the build process? See - v4.1.3 contains only 28 files, and v4.1.2 contains 42.

farfromrefug commented 9 months ago

@lekhmanrus indeed: there is a build error:

../../src/https/angular/ns-http-xhr-backend.ts:2:80 - error TS2459: Module '"@angular/common/http"' declares 'XhrFactory' locally, but it is not exported.

2 import { HttpErrorResponse, HttpEvent, HttpHeaders, HttpRequest, HttpResponse, XhrFactory } from '@angular/common/http';

any idea? and there is another error. My build process does not stop on error...

lekhmanrus commented 8 months ago

@farfromrefug, Yep, in Angular v16 XhrFactory export from @angular/common/http has been removed. I'll fix that shortly.