CSS Improvements in tns-ios 3.3.0 breaks plugin

nativescript-community / nativescript-drawingpad

:pencil: NativeScript plugin to provide a way to capture any drawing (signatures are a common use case) from the device

Apache License 2.0

90 stars 32 forks source link

CSS Improvements in tns-ios 3.3.0 breaks plugin #27

Closed manojdcoder closed 6 years ago

manojdcoder commented 6 years ago

After upgrading to {N} 3.3.0, the following issues were observed in iOS version. Android still works as expected.

height via CSS is not honored, only inline height attribute is effective.
Setting / updating penColor / penWidth doesn't make any difference.

Issues can be easily reproduced by updating the tns-ios to 3.3.0 in demo app.

manojdcoder commented 6 years ago

@bradmartin Did you have a chance to check this? Any possible workaround / directions you could give me?

manojdcoder commented 6 years ago

@bradmartin As far I understood from release notes of {N} 3.3.0, css is now applied in onLoaded callback. Calling the super.onLoaded() did the trick, would be great if you take a moment to review & merge and push a release to NPM.