search

nativescript-community / nativescript-drawingpad

:pencil: NativeScript plugin to provide a way to capture any drawing (signatures are a common use case) from the device
Apache License 2.0
90 stars 32 forks source link

ProductFlavours missing for Android #38

Closed hypery2k closed 6 years ago

hypery2k commented 6 years ago

The code in include.gradle does not define any productFlavour, as needed:

https://github.com/bradmartin/nativescript-drawingpad/blob/824cc43b45bb7dda6d0b873bab9b643e2db0690a/src/platforms/android/include.gradle#L2-L4

bradmartin commented 6 years ago

for NS 4x you shouldn't need that anymore for the build, are you having issues with NS4x or 3x, if less than 4x use the previous with the productFlavor I suppose, we can document this on the README. I've done that on a few other plugins and it seems to work fine.

bradmartin commented 6 years ago

Which is what this new cmd for 4x does more or less - https://github.com/bradmartin/nativescript-drawingpad/blob/master/src/scripts/build-native.js#L16

hypery2k commented 6 years ago

ok, thanks for the hint