search

nativescript-community / nativescript-vscode-extension

A Visual Studio Code Extension for NativeScript
https://www.nativescript.org/visual-studio-code
Apache License 2.0
82 stars 32 forks source link

When the TNS process is finished - terminate the debugger process, too. #127

Closed yyosifov closed 7 years ago

yyosifov commented 7 years ago

When the TNS process has been closed we're still hanging the debugger as if you can still do something.

This is easily reproducible if there is need for interactive input from the user. For example if you have two provisioning profiles and run launch ios from the app it will try to find a provisioning profile for you, get confused, can't get a decision and return an error for you to pass the teamId as an arg. After that the TNS exits. Currently we hang, now we raise the terminate event.

Another way to test:

yyosifov commented 7 years ago

@ivanbuhov great catch! I've added your comment + condition for code > 0 to handle this case