search

nativescript-community / nativescript-vscode-extension

A Visual Studio Code Extension for NativeScript
https://www.nativescript.org/visual-studio-code
Apache License 2.0
82 stars 32 forks source link

Add Loaded Scripts #191

Open ivanovit opened 6 years ago

ivanovit commented 6 years ago

The code is very similar to the default nodejs implementation but it is active only for several debug requests.

https://github.com/Microsoft/vscode-node-debug/blob/52723cea407f9d152064df9c3f397475258d0bfd/src/node/extension/loadedScripts.ts#L98

Moving the LoadedScript explorer into VS Code core is on the 6 month roadmap of vscode so this code be unnecessary after that.

Screenshots: 2018-07-03_1556

cla-bot[bot] commented 4 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. CLA has not been signed by users: @ivanovit. After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

NathanWalker commented 4 years ago

@ivanovit curious on this changeset? we were looking to merge some of these long standing pr's - do you believe this is still relevant?

ivanovit commented 4 years ago

Hi @NathanWalker,

It was a long time ago and I'm not sure it is still relevant. The LoadedScript explorer should now be a part of VSCode core which will make this PR irrelevant.