Allow for 'tns' platform specific files

nativescript-community / nativescript-vscode-extension

A Visual Studio Code Extension for NativeScript

https://www.nativescript.org/visual-studio-code

Apache License 2.0

82 stars 32 forks source link

Allow for 'tns' platform specific files #259

Closed joshcomley closed 4 years ago

joshcomley commented 5 years ago

See https://github.com/NativeScript/nativescript-vscode-extension/issues/252

Allowing for debugging platform specific files at the higher ".tns.[ext]" level.

cla-bot[bot] commented 5 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. CLA has not been signed by users: @joshcomley. After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

joshcomley commented 5 years ago

@cla-bot check

cla-bot[bot] commented 5 years ago

The cla-bot has been summoned, and re-checked this pull request!

joshcomley commented 4 years ago

Please can somebody review this - my plugin just updated automatically from my own version and it broke debugging in multi-environment projects.

Fatme commented 4 years ago

Hey @joshcomley,

Really sorry for the late reply!

We've reviewed your code and it seems your application is with legacy code-shared structure. If this is the case, you can follow the steps described here in order to migrate to the new structure. So, no additional logic will be needed in vscode-extension.

However, the fix seems safe so I'll merge the PR.

joshcomley commented 4 years ago

@Fatme Thanks for the update! Is there an updated sample project with the new structure somewhere I can reference? Ideally Angular etc.

Fatme commented 4 years ago

@joshcomley,

Yep, we have an updated project here. Reviewing the history of the repo, you can see how it is migrated. Maybe the most interesting commits are the followings:

https://github.com/NativeScript/north-star/commit/fc422e93f2ad5dd007a15e833d3be32e7c673aa1 - All relative imports are updated to start with @src symbol
https://github.com/NativeScript/north-star/commit/3ce77d9fca7c13cf445fcbeb527bc9298f91b3c8 - The required changes are applied into tsconfig files
https://github.com/NativeScript/north-star/commit/d8a17b690a249636ce94c40bebd149233ed328c0 - @nativescript/tslint-rules package is added.

joshcomley commented 4 years ago

@Fatme thank you so much, I will have a look through all that