Closed joshcomley closed 4 years ago
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @joshcomley.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check
as a comment to the PR.
@cla-bot check
The cla-bot has been summoned, and re-checked this pull request!
Please can somebody review this - my plugin just updated automatically from my own version and it broke debugging in multi-environment projects.
Hey @joshcomley,
Really sorry for the late reply!
We've reviewed your code and it seems your application is with legacy code-shared structure. If this is the case, you can follow the steps described here in order to migrate to the new structure. So, no additional logic will be needed in vscode-extension
.
However, the fix seems safe so I'll merge the PR.
@Fatme Thanks for the update! Is there an updated sample project with the new structure somewhere I can reference? Ideally Angular etc.
@joshcomley,
Yep, we have an updated project here. Reviewing the history of the repo, you can see how it is migrated. Maybe the most interesting commits are the followings:
@src
symboltsconfig
files@nativescript/tslint-rules
package is added.@Fatme thank you so much, I will have a look through all that
See https://github.com/NativeScript/nativescript-vscode-extension/issues/252
Allowing for debugging platform specific files at the higher ".tns.[ext]" level.